You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jeffrey Smith (Code Review)" <ge...@cloudera.org> on 2025/07/19 20:55:04 UTC
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/23196
to review the following change.
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
KUDU-3678: Fix cmake compilation in MacOS
This patch fixes compiling cmake in MacOS by removing an old define
that sets fdopen to NULL. This change is already present in cmake
version 3.30 and greater.
Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/cmake-fix-macos-compilation.patch
2 files changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/23196/1
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23196 )
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1584/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 19 Jul 2025 21:54:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23196 )
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1584/
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 19 Jul 2025 20:55:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23196 )
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
Patch Set 1: Verified+1
unrelated test failures (known flaky tests):
* DEBUG: org.apache.kudu.backup.TestKuduBackup
* RELEASE: rebalancer_tool-test
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 20 Jul 2025 19:11:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23196 )
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
Patch Set 1: Code-Review+2
Thank you for addressing this!
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 20 Jul 2025 19:18:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3678: Fix cmake compilation in MacOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23196 )
Change subject: KUDU-3678: Fix cmake compilation in MacOS
......................................................................
KUDU-3678: Fix cmake compilation in MacOS
This patch fixes compiling cmake in MacOS by removing an old define
that sets fdopen to NULL. This change is already present in cmake
version 3.30 and greater.
Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Reviewed-on: http://gerrit.cloudera.org:8080/23196
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/cmake-fix-macos-compilation.patch
2 files changed, 22 insertions(+), 3 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/23196
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ceec62d5c0fd7ff1564fec10ab4761b699c4e6d
Gerrit-Change-Number: 23196
Gerrit-PatchSet: 2
Gerrit-Owner: Jeffrey Smith <je...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)