[GitHub] [spark] HyukjinKwon commented on a change in pull request #27860: [SPARK-31101][SQL][BUILD] Upgrade Janino to 3.1.2

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27860: [SPARK-31101][SQL][BUILD] Upgrade Janino to 3.1.2
URL: https://github.com/apache/spark/pull/27860#discussion_r395047338
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ##########
 @@ -1402,9 +1403,10 @@ object CodeGenerator extends Logging {
   private def updateAndGetCompilationStats(evaluator: ClassBodyEvaluator): ByteCodeStats = {
     // First retrieve the generated classes.
     val classes = {
-      val resultField = classOf[SimpleCompiler].getDeclaredField("result")
-      resultField.setAccessible(true)
-      val loader = resultField.get(evaluator).asInstanceOf[ByteArrayClassLoader]
+      val scField = classOf[ClassBodyEvaluator].getDeclaredField("sc")
+      scField.setAccessible(true)
+      val compiler = scField.get(evaluator).asInstanceOf[SimpleCompiler]
+      val loader = compiler.getClassLoader.asInstanceOf[ByteArrayClassLoader]
 
 Review comment:
   For my own note, I checked https://github.com/janino-compiler/janino/commit/9e0c16c69c166f83541d63df70b42c9fbc278536

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org