You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2016/01/21 11:43:51 UTC
[GitHub] flink pull request: [FLINK-3270] Add Kafka example
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1533
[FLINK-3270] Add Kafka example
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3270
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1533.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1533
----
commit 75cfb7c8d63bed8b367fd9aa7d09ccf1b51b4bd5
Author: Robert Metzger <rm...@apache.org>
Date: 2016-01-21T10:42:12Z
[FLINK-3270] Add Kafka example
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3270] Add Kafka example
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-182779503
I think Robert has a good point.
The examples should follow the implementations of the other examples after the rework in PR #1581.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3270] Add Kafka example
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3270] Add Kafka example
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-174964868
Not quite sure about adding examples for the connectors to the examples project. If we do that for all connectors, it becomes heavily loaded with dependencies.
Can the example not be in the kafka connector project?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3270] Add Kafka example
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1533#issuecomment-175544829
I understand that argument, and I would be strongly against adding examples for each connector.
The pull request is moving the example away from the Kafka project into the main Flink examples.
The reasons why I wanted to have Kafka in the main examples:
- Almost all Flink users I know are using Kafka, so its important to place the example prominently.
- Its very handy to deploy a Kafka example with the binary distribution to quickly test if flink is properly working on a cluster with Kafka (instead of building a separate project somewhere)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---