[GitHub] [incubator-superset] elibrumbaugh commented on issue #7047: feat: add warning message when saving title from explore

[GitBox <gi...@apache.org>]

elibrumbaugh commented on issue #7047: feat: add warning message when saving title from explore
URL: https://github.com/apache/incubator-superset/pull/7047#issuecomment-476866779
 
 
   Thanks for sharing this @michellethomas !
   
   A few thoughts:
   
   - If we take the warning route could we add additional context to that warning message. For example I would like to better understand what it means to save over an existing chart. What are the implications?
   - We should center the warning on the screen so we're not covering up what is being referenced (in this case the chart title).
   - I agree with Max that having to close out a warning message every time I change the title of a chart isn't an ideal experience. I would expect that I could change that name without issue.
   
   Personally I think there's a lot of value in pushing for a more dashboard like editing experience. We should explore it, communicate it out and see if there is push back.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org