You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/07/20 18:50:20 UTC
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13888
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
IMPALA-8776: Bump timeout in test_event_processing
This change increases the timeout in test_event_processing and adds a
delay between repeated reads of the /events page. The latter should
reduce load on the catalog, which should further reduce the chance of
hitting a timeout.
Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
---
M tests/custom_cluster/test_event_processing.py
1 file changed, 47 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/13888/1
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 2: Code-Review+1
Thanks for doing this Lars. The change looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jul 2019 15:22:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3933/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jul 2019 19:48:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jul 2019 16:37:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3932/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jul 2019 19:30:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@123
PS1, Line 123: ;
> flake8: E703 statement ends with a semicolon
Done
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@137
PS1, Line 137: s
> flake8: E731 do not assign a lambda expression, use a def
Done
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@138
PS1, Line 138:
> flake8: E201 whitespace after '['
Done
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@138
PS1, Line 138:
> flake8: E202 whitespace before ']'
Done
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jul 2019 19:07:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jul 2019 23:27:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jul 2019 16:56:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@123
PS1, Line 123: ;
flake8: E703 statement ends with a semicolon
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@137
PS1, Line 137: s
flake8: E731 do not assign a lambda expression, use a def
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@138
PS1, Line 138:
flake8: E201 whitespace after '['
http://gerrit.cloudera.org:8080/#/c/13888/1/tests/custom_cluster/test_event_processing.py@138
PS1, Line 138:
flake8: E202 whitespace before ']'
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jul 2019 18:50:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13888
to look at the new patch set (#2).
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
IMPALA-8776: Bump timeout in test_event_processing
This change increases the timeout in test_event_processing and adds a
delay between repeated reads of the /events page. The latter should
reduce load on the catalog, which should further reduce the chance of
hitting a timeout.
Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
---
M tests/custom_cluster/test_event_processing.py
1 file changed, 49 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/13888/2
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4630/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Jul 2019 16:56:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8776: Bump timeout in test event processing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13888 )
Change subject: IMPALA-8776: Bump timeout in test_event_processing
......................................................................
IMPALA-8776: Bump timeout in test_event_processing
This change increases the timeout in test_event_processing and adds a
delay between repeated reads of the /events page. The latter should
reduce load on the catalog, which should further reduce the chance of
hitting a timeout.
Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Reviewed-on: http://gerrit.cloudera.org:8080/13888
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_event_processing.py
1 file changed, 49 insertions(+), 40 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I42d278209b9c01eba44decf1972930afd72522e9
Gerrit-Change-Number: 13888
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>