You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2012/12/24 01:02:13 UTC
[jira] [Commented] (HBASE-7430) TestSnapshotDescriptionUtils break
compaction/scanner tests (EnvironmentEdge issue)
[ https://issues.apache.org/jira/browse/HBASE-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539125#comment-13539125 ]
Jonathan Hsieh commented on HBASE-7430:
---------------------------------------
lgtm. +1. It knocked off a bunch of test failures on my test runs, but not everything.
> TestSnapshotDescriptionUtils break compaction/scanner tests (EnvironmentEdge issue)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-7430
> URL: https://issues.apache.org/jira/browse/HBASE-7430
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: hbase-6055
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Blocker
> Fix For: hbase-6055, 0.96.0
>
> Attachments: HBASE-7430-v0.patch
>
>
> I've some tests failing due to TestSnapshotDescriptionUtils.testValidateDescriptor()
> the problem is related to the EnvironmentEdgeManager.injectEdge() that is not restored, at the end of the test.
> I think that the main problem is (HBASE-5048) that we're still mixing System.currentTimeMillis() and EnvironmentEdgeManager.currentTimeMillis()
> so, using EnvEdge.reset() can still have some problem ~1ms skew with the timeMillis()
> All the tests that uses EnvEdge.injectEdge() are MediumTest, so they are running in a different JVM, and everything is fine. This one is SmallTest as the other one playing with compaction and scanner.
> {code}
> org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[0]
> org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[1]
> org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[2]
> org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[3]
> org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[4]
> org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL.testScannerSelection[5]
> org.apache.hadoop.hbase.regionserver.TestCompaction.testMajorCompaction
> org.apache.hadoop.hbase.regionserver.TestCompaction.testDataBlockEncodingInCacheOnly
> org.apache.hadoop.hbase.regionserver.TestCompaction.testDataBlockEncodingEverywhere
> org.apache.hadoop.hbase.regionserver.TestCompaction.testMinorCompactionWithDeleteRow
> org.apache.hadoop.hbase.regionserver.TestCompaction.testMinorCompactionWithDeleteColumn1
> org.apache.hadoop.hbase.regionserver.TestCompaction.testMinorCompactionWithDeleteColumnFamily
> org.apache.hadoop.hbase.regionserver.TestCompaction.testInterruptCompaction
> org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testBasicScenario
> org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testRawScanWithoutKeepingDeletes
> org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testWithoutKeepingDeletes
> org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testDeleteMarkerExpirationEmptyStore
> org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testDeleteMarkerExpiration
> org.apache.hadoop.hbase.regionserver.TestKeepDeletes.testWithMinVersions
> org.apache.hadoop.hbase.regionserver.TestMinVersions.testDelete
> org.apache.hadoop.hbase.regionserver.TestMinVersions.testGetClosestBefore
> org.apache.hadoop.hbase.regionserver.TestMinVersions.testStoreMemStore
> org.apache.hadoop.hbase.regionserver.TestMinVersions.testMemStore
> org.apache.hadoop.hbase.regionserver.TestMinVersions.testBaseCase
> org.apache.hadoop.hbase.regionserver.TestMinVersions.testFilters
> org.apache.hadoop.hbase.regionserver.TestQueryMatcher.testMatch_ExpiredExplicit
> org.apache.hadoop.hbase.regionserver.TestQueryMatcher.testMatch_ExpiredWildcard
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira