You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/09/02 04:00:19 UTC

[kudu-CR] [thirdparty] update yaml-cpp up to version 0.9.0

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24783


Change subject: [thirdparty] update yaml-cpp up to version 0.9.0
......................................................................

[thirdparty] update yaml-cpp up to version 0.9.0

Along with several improvements and fixes since 0.8.0, new version
allows for building yaml-cpp with GCC-15 (e.g., at Ubuntu 26).

In yaml-cpp 0.9.0 a new option YAML_ENABLE_PIC was introduced, so let's
use it instead of manually adding -fPIC flag to the CC/CXX flags.

Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 6 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/24783/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] WIP [thirdparty] update yaml-cpp up to version 0.9.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24783

to look at the new patch set (#2).

Change subject: WIP [thirdparty] update yaml-cpp up to version 0.9.0
......................................................................

WIP [thirdparty] update yaml-cpp up to version 0.9.0

Along with several improvements and fixes since 0.8.0, new version
allows for building yaml-cpp with GCC-15 (e.g., at Ubuntu 26).

In yaml-cpp 0.9.0 a new option YAML_ENABLE_PIC was introduced, so let's
use it instead of manually adding -fPIC flag to the CC/CXX flags.

DONT_BUILD

WIP:
  * make sure everything compiles and tests pass

Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
---
M thirdparty/build-definitions.sh
M thirdparty/vars.sh
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/24783/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] WIP [thirdparty] update yaml-cpp up to version 0.9.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Zoltan Martonka from this change.  ( http://gerrit.cloudera.org:8080/24783 )

Change subject: WIP [thirdparty] update yaml-cpp up to version 0.9.0
......................................................................


Removed reviewer Zoltan Martonka.
-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................

[thirdparty] update yaml-cpp up to 0.9.0 version

Along with several improvements and fixes since 0.8.0, the new version
allows for building yaml-cpp with GCC-15 (e.g., on Ubuntu 26), so no
extra patches are necessary on top of the upstream source code.

In yaml-cpp 0.9.0 a new option YAML_ENABLE_PIC was introduced.  Let's
use it instead of manually adding -fPIC to the CC/CXX flags.  With 0.9.0
version, enforcing the C++17 standard is necessary to avoid errors when
compiling with CLANG-11 [1].

[1] https://github.com/jbeder/yaml-cpp/issues/1334

Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Reviewed-on: http://gerrit.cloudera.org:8080/24783
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/yamlreader.cc
M thirdparty/build-definitions.sh
D thirdparty/patches/yaml-fix-missing-cstdint-for-GCC15.patch
M thirdparty/vars.sh
4 files changed, 20 insertions(+), 60 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24783

to look at the new patch set (#3).

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................

[thirdparty] update yaml-cpp up to 0.9.0 version

Along with several improvements and fixes since 0.8.0, the new version
allows for building yaml-cpp with GCC-15 (e.g., on Ubuntu 26), so no
extra patches are necessary on top of the upstream source code.

In yaml-cpp 0.9.0 a new option YAML_ENABLE_PIC was introduced.  Let's
use it instead of manually adding -fPIC to the CC/CXX flags.  With 0.9.0
version, enforcing the C++17 standard is necessary to avoid errors when
compiling with CLANG-11 [1].

[1] https://github.com/jbeder/yaml-cpp/issues/1334

Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
---
M src/kudu/util/yamlreader.cc
M thirdparty/build-definitions.sh
D thirdparty/patches/yaml-fix-missing-cstdint-for-GCC15.patch
M thirdparty/vars.sh
4 files changed, 20 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/24783/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2943/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 03:18:28 +0000
Gerrit-HasComments: No

[kudu-CR] WIP [thirdparty] update yaml-cpp up to version 0.9.0

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Abhishek Chennaka from this change.  ( http://gerrit.cloudera.org:8080/24783 )

Change subject: WIP [thirdparty] update yaml-cpp up to version 0.9.0
......................................................................


Removed reviewer Abhishek Chennaka.
-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 22:27:49 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2943/


-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 09 Sep 2026 02:26:16 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] update yaml-cpp up to version 0.9.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to version 0.9.0
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/2933/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2026 04:10:28 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................


Patch Set 3: Verified+1

unrelated failures of known flaky tests


-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 03:36:38 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] update yaml-cpp up to 0.9.0 version

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [thirdparty] update yaml-cpp up to 0.9.0 version
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [thirdparty] update yaml-cpp up to version 0.9.0

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24783 )

Change subject: [thirdparty] update yaml-cpp up to version 0.9.0
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2933/


-- 
To view, visit http://gerrit.cloudera.org:8080/24783
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcce22fef6b1e1ce4e31dfab9224a1957e6a1022
Gerrit-Change-Number: 24783
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Sep 2026 04:00:25 +0000
Gerrit-HasComments: No