[GitHub] [tvm] driazati commented on a diff in pull request #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests

[GitBox <gi...@apache.org>]

driazati commented on code in PR #12011:
URL: https://github.com/apache/tvm/pull/12011#discussion_r914209498


##########
tests/scripts/ci.py:
##########
@@ -394,7 +396,9 @@ def fn(
         # Add named test suites
         for option_name, (_, extra_scripts) in options.items():
             if kwargs.get(option_name, False):
-                scripts += extra_scripts
+                scripts.extend(
+                    script.format(name=name, build_dir=build_dir) for script in extra_scripts

Review Comment:
   is `name` actually used anywhere?
   ```suggestion
                       script.format(build_dir=build_dir) for script in extra_scripts
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org