[jira] [Commented] (NET-426) FTPS: Hook to customize _openDataConnection_ SSLSocket before startHandshake() is called

["Ralf Hauser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NET-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284248#comment-15284248 ] 

Ralf Hauser commented on NET-426:
---------------------------------

with commons-net 3.3 it only worked, once I 
http://stackoverflow.com/questions/32398754/how-to-connect-to-ftps-server-with-data-connection-using-same-tls-session
had problems to get preferences in the cyberduck example, but if I set always to "true" got it working.

Even better if you store the session not only under the key based on 
socket.getInetAddress().getHostName()
but also a second time under
socket.getInetAddress().getHostAddress()

> FTPS: Hook to customize _openDataConnection_ SSLSocket before startHandshake() is called
> ----------------------------------------------------------------------------------------
>
>                 Key: NET-426
>                 URL: https://issues.apache.org/jira/browse/NET-426
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.0.1
>            Reporter: Ketan
>             Fix For: 3.1, 3.2
>
>         Attachments: FTPSClient.patch, FTPSClient.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Currently in FTPSClient class, there is protected _openDataConnection_ method, which create SSLSocket for data connection.  But there is no hook to customize the SSLSocket before startHandshake is called.  
> I need to know the remote host ip and port, which i can get for socket, and do custom setup to try to reuse SSL sessions from control connection socket.  Since the socket factory uses createSocket() method, I can't just use custom socket factory since I don't know the host and port.  I can't just override the _openDataConnection_() method in my class since that will call the startHandshake().  
> So it would be nice if you can provide hook, much like _connectAction_(), but for data connection before handshake is started.  You can pass the new data socket as argument to this hook method so one can get remote host and port information.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)