You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/05 11:51:51 UTC
[GitHub] [ratis] leo65535 opened a new pull request, #705: RATIS-1660. Fix wrong ratis package
leo65535 opened a new pull request, #705:
URL: https://github.com/apache/ratis/pull/705
## What changes were proposed in this pull request?
There are some module files are missing in relase package, like examples, lib, ratis-shell, etc.
When we download the relase package and untar it, http://archive.apache.org/dist/ratis/2.3.0/
```
[dcadmin@dcadmin-work ratis]$ ll apache-ratis-2.3.0
total 40
drwxr-xr-x 7 dcadmin dcadmin 212 Jan 22 2020 dev-support
drwxr-xr-x 7 dcadmin dcadmin 176 Jan 22 2020 docs
drwxrwxr-x 2 dcadmin dcadmin 4096 Aug 5 19:51 jars
-rw-r--r-- 1 dcadmin dcadmin 19399 Jan 22 2020 LICENSE
-rw-r--r-- 1 dcadmin dcadmin 11325 Jan 22 2020 NOTICE
-rw-r--r-- 1 dcadmin dcadmin 1201 Jan 22 2020 README.md
```
After patch
```
[dcadmin@dcadmin-work ratis-assembly]$ ll apache-ratis-3.0.0-SNAPSHOT/
total 76
drwxr-xr-x 2 dcadmin dcadmin 19 Aug 5 19:40 bin
-rw-r--r-- 1 dcadmin dcadmin 2648 Jan 22 2020 BUILDING.md
drwxr-xr-x 2 dcadmin dcadmin 30 Aug 5 19:40 conf
drwxr-xr-x 7 dcadmin dcadmin 212 Aug 5 19:40 dev-support
drwxr-xr-x 5 dcadmin dcadmin 40 Jan 22 2020 examples
drwxr-xr-x 3 dcadmin dcadmin 19 Jan 22 2020 lib
drwxr-xr-x 2 dcadmin dcadmin 35 Aug 5 19:40 libexec
-rw-r--r-- 1 dcadmin dcadmin 13394 Jan 22 2020 LICENSE
-rw-r--r-- 1 dcadmin dcadmin 5246 Jan 22 2020 NOTICE
-rw-r--r-- 1 dcadmin dcadmin 37579 Jan 22 2020 pom.xml
drwxr-xr-x 6 dcadmin dcadmin 55 Jan 22 2020 ratis-shell
-rw-r--r-- 1 dcadmin dcadmin 1201 Jan 22 2020 README.md
-rw-r--r-- 1 dcadmin dcadmin 1905 Jan 22 2020 start-build-env.sh
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1660
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941974413
##########
ratis-assembly/src/main/assembly/bin.xml:
##########
@@ -77,35 +77,35 @@
<directoryMode>0755</directoryMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/target/</directory>
- <outputDirectory>ratis-shell/lib/shell</outputDirectory>
- <fileMode>755</fileMode>
- <includes>
- <include>ratis-shell-*-jar-with-dependencies.jar</include>
- </includes>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/bin</directory>
- <outputDirectory>ratis-shell/bin</outputDirectory>
- <fileMode>755</fileMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/libexec</directory>
- <outputDirectory>ratis-shell/libexec</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/conf</directory>
- <outputDirectory>ratis-shell/conf</outputDirectory>
- <fileMode>644</fileMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/target/</directory>-->
+<!-- <outputDirectory>ratis-shell/lib/shell</outputDirectory>-->
+<!-- <fileMode>755</fileMode>-->
+<!-- <includes>-->
+<!-- <include>ratis-shell-*-jar-with-dependencies.jar</include>-->
+<!-- </includes>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/bin</directory>-->
+<!-- <outputDirectory>ratis-shell/bin</outputDirectory>-->
+<!-- <fileMode>755</fileMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/libexec</directory>-->
+<!-- <outputDirectory>ratis-shell/libexec</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/conf</directory>-->
+<!-- <outputDirectory>ratis-shell/conf</outputDirectory>-->
+<!-- <fileMode>644</fileMode>-->
+<!-- </fileSet>-->
Review Comment:
Close the comment now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941915828
##########
ratis-assembly/src/main/assembly/bin.xml:
##########
@@ -77,35 +77,35 @@
<directoryMode>0755</directoryMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/target/</directory>
- <outputDirectory>ratis-shell/lib/shell</outputDirectory>
- <fileMode>755</fileMode>
- <includes>
- <include>ratis-shell-*-jar-with-dependencies.jar</include>
- </includes>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/bin</directory>
- <outputDirectory>ratis-shell/bin</outputDirectory>
- <fileMode>755</fileMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/libexec</directory>
- <outputDirectory>ratis-shell/libexec</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/conf</directory>
- <outputDirectory>ratis-shell/conf</outputDirectory>
- <fileMode>644</fileMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/target/</directory>-->
+<!-- <outputDirectory>ratis-shell/lib/shell</outputDirectory>-->
+<!-- <fileMode>755</fileMode>-->
+<!-- <includes>-->
+<!-- <include>ratis-shell-*-jar-with-dependencies.jar</include>-->
+<!-- </includes>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/bin</directory>-->
+<!-- <outputDirectory>ratis-shell/bin</outputDirectory>-->
+<!-- <fileMode>755</fileMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/libexec</directory>-->
+<!-- <outputDirectory>ratis-shell/libexec</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/conf</directory>-->
+<!-- <outputDirectory>ratis-shell/conf</outputDirectory>-->
+<!-- <fileMode>644</fileMode>-->
+<!-- </fileSet>-->
Review Comment:
Hi @szetszwo, the content in `ratis-shell` are already in the root dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1207624032
cc @szetszwo, take a look when free, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo merged pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #705:
URL: https://github.com/apache/ratis/pull/705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941974492
##########
ratis-assembly/src/main/assembly/examples-bin.xml:
##########
@@ -68,12 +68,12 @@
<fileMode>755</fileMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
Review Comment:
Close the comment now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1208373440
@leo65535 , thanks for working on this. Will try the change later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941611691
##########
ratis-assembly/src/main/assembly/examples-bin.xml:
##########
@@ -68,12 +68,12 @@
<fileMode>755</fileMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
Review Comment:
Why commenting all these lines? For debugging?
##########
pom.xml:
##########
@@ -176,6 +176,7 @@
<maven-stylus-skin.version>1.5</maven-stylus-skin.version>
<maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version>
<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
+ <maven-assembly-plugin.version>3.4.1</maven-assembly-plugin.version>
Review Comment:
Sorry, I mean we should update the apache parent pom to version 27. Then, we don't need to add maven-assembly-plugin.version here. See below:
```
+++ b/pom.xml
@@ -18,7 +18,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
- <version>23</version>
+ <version>27</version>
<relativePath /> <!-- resolve from repository -->
</parent>
@@ -176,7 +176,6 @@
<maven-stylus-skin.version>1.5</maven-stylus-skin.version>
<maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version>
<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
- <maven-assembly-plugin.version>3.4.1</maven-assembly-plugin.version>
<checkstyle.version>9.3</checkstyle.version>
@@ -522,7 +522,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
- <version>${maven-assembly-plugin.version}</version>
<configuration>
<!--Defer to the ratis-assembly sub-module. It does all assembly-->
<skipAssembly>true</skipAssembly>
```
##########
ratis-assembly/pom.xml:
##########
@@ -123,14 +124,42 @@
<skipAssembly>false</skipAssembly>
<appendAssemblyId>true</appendAssemblyId>
<tarLongFileMode>gnu</tarLongFileMode>
- <descriptors>
- <descriptor>src/main/assembly/src.xml</descriptor>
- <descriptor>src/main/assembly/bin.xml</descriptor>
- <descriptor>src/main/assembly/examples-bin.xml</descriptor>
- <descriptor>src/main/assembly/shell-bin.xml</descriptor>
- </descriptors>
</configuration>
+ <executions>
+ <execution>
+ <id>src</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/src.xml</descriptor>
+ </descriptors>
+ <finalName>apache-ratis-${project.version}-src</finalName>
+ <appendAssemblyId>false</appendAssemblyId>
+ </configuration>
+ </execution>
+ <execution>
+ <id>default-cli</id>
Review Comment:
@leo65535 , thanks for trying it. I did not know that `default-cli` is a special id in maven so that we cannot change simply change it; see https://maven.apache.org/guides/mini/guide-default-execution-ids.html . Let's keep using `default-cli` then.
##########
ratis-assembly/src/main/assembly/bin.xml:
##########
@@ -77,35 +77,35 @@
<directoryMode>0755</directoryMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/target/</directory>
- <outputDirectory>ratis-shell/lib/shell</outputDirectory>
- <fileMode>755</fileMode>
- <includes>
- <include>ratis-shell-*-jar-with-dependencies.jar</include>
- </includes>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/bin</directory>
- <outputDirectory>ratis-shell/bin</outputDirectory>
- <fileMode>755</fileMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/libexec</directory>
- <outputDirectory>ratis-shell/libexec</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
- <fileSet>
- <directory>${project.basedir}/../ratis-shell/src/main/conf</directory>
- <outputDirectory>ratis-shell/conf</outputDirectory>
- <fileMode>644</fileMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/target/</directory>-->
+<!-- <outputDirectory>ratis-shell/lib/shell</outputDirectory>-->
+<!-- <fileMode>755</fileMode>-->
+<!-- <includes>-->
+<!-- <include>ratis-shell-*-jar-with-dependencies.jar</include>-->
+<!-- </includes>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/bin</directory>-->
+<!-- <outputDirectory>ratis-shell/bin</outputDirectory>-->
+<!-- <fileMode>755</fileMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/libexec</directory>-->
+<!-- <outputDirectory>ratis-shell/libexec</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../ratis-shell/src/main/conf</directory>-->
+<!-- <outputDirectory>ratis-shell/conf</outputDirectory>-->
+<!-- <fileMode>644</fileMode>-->
+<!-- </fileSet>-->
Review Comment:
Why commenting all these lines? For debugging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941916782
##########
ratis-assembly/pom.xml:
##########
@@ -123,14 +124,42 @@
<skipAssembly>false</skipAssembly>
<appendAssemblyId>true</appendAssemblyId>
<tarLongFileMode>gnu</tarLongFileMode>
- <descriptors>
- <descriptor>src/main/assembly/src.xml</descriptor>
- <descriptor>src/main/assembly/bin.xml</descriptor>
- <descriptor>src/main/assembly/examples-bin.xml</descriptor>
- <descriptor>src/main/assembly/shell-bin.xml</descriptor>
- </descriptors>
</configuration>
+ <executions>
+ <execution>
+ <id>src</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/src.xml</descriptor>
+ </descriptors>
+ <finalName>apache-ratis-${project.version}-src</finalName>
+ <appendAssemblyId>false</appendAssemblyId>
+ </configuration>
+ </execution>
+ <execution>
+ <id>default-cli</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/bin.xml</descriptor>
+ <descriptor>src/main/assembly/examples-bin.xml</descriptor>
+ <descriptor>src/main/assembly/shell-bin.xml</descriptor>
+ <descriptor>src/main/assembly/pkg.xml</descriptor>
Review Comment:
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941648109
##########
pom.xml:
##########
@@ -176,6 +176,7 @@
<maven-stylus-skin.version>1.5</maven-stylus-skin.version>
<maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version>
<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
+ <maven-assembly-plugin.version>3.4.1</maven-assembly-plugin.version>
Review Comment:
Just tried it but there were some failures. Let's don't update apache parent version for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r940922919
##########
ratis-assembly/src/main/assembly/pkg.xml:
##########
@@ -0,0 +1,28 @@
+<?xml version="1.0"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+-->
+<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
+ <id>pkg</id>
Review Comment:
Got.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r940922571
##########
ratis-assembly/pom.xml:
##########
@@ -123,14 +124,42 @@
<skipAssembly>false</skipAssembly>
<appendAssemblyId>true</appendAssemblyId>
<tarLongFileMode>gnu</tarLongFileMode>
- <descriptors>
- <descriptor>src/main/assembly/src.xml</descriptor>
- <descriptor>src/main/assembly/bin.xml</descriptor>
- <descriptor>src/main/assembly/examples-bin.xml</descriptor>
- <descriptor>src/main/assembly/shell-bin.xml</descriptor>
- </descriptors>
</configuration>
+ <executions>
+ <execution>
+ <id>src</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/src.xml</descriptor>
+ </descriptors>
+ <finalName>apache-ratis-${project.version}-src</finalName>
+ <appendAssemblyId>false</appendAssemblyId>
+ </configuration>
+ </execution>
+ <execution>
+ <id>default-cli</id>
Review Comment:
Hi @szetszwo, I had tried use `bin`, the build command will be failed.
```
./dev-support/checks/build.sh -Prelease assembly:single
```
```
[INFO] --- maven-assembly-plugin:3.4.1:single (default-cli) @ ratis-assembly ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.224 s
[INFO] Finished at: 2022-08-09T13:49:16+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.4.1:single (default-cli) on project ratis-assembly: Error reading assemblies: No assembly descriptors found. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941655170
##########
ratis-assembly/pom.xml:
##########
@@ -123,14 +124,42 @@
<skipAssembly>false</skipAssembly>
<appendAssemblyId>true</appendAssemblyId>
<tarLongFileMode>gnu</tarLongFileMode>
- <descriptors>
- <descriptor>src/main/assembly/src.xml</descriptor>
- <descriptor>src/main/assembly/bin.xml</descriptor>
- <descriptor>src/main/assembly/examples-bin.xml</descriptor>
- <descriptor>src/main/assembly/shell-bin.xml</descriptor>
- </descriptors>
</configuration>
+ <executions>
+ <execution>
+ <id>src</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/src.xml</descriptor>
+ </descriptors>
+ <finalName>apache-ratis-${project.version}-src</finalName>
+ <appendAssemblyId>false</appendAssemblyId>
+ </configuration>
+ </execution>
+ <execution>
+ <id>default-cli</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/bin.xml</descriptor>
+ <descriptor>src/main/assembly/examples-bin.xml</descriptor>
+ <descriptor>src/main/assembly/shell-bin.xml</descriptor>
+ <descriptor>src/main/assembly/pkg.xml</descriptor>
Review Comment:
@leo65535 , Please rename the file to bin-pkg.xml. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1209715215
> How about exclude the example folder currently? like before. http://archive.apache.org/dist/ratis/2.3.0/apache-ratis-2.3.0-bin.tar.gz
>
> And, I raised a new issue to solve the problem https://issues.apache.org/jira/browse/RATIS-1667
Sure, let's exclude the example folder here and fix it in RATIS-1667. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r940920572
##########
pom.xml:
##########
@@ -176,6 +176,7 @@
<maven-stylus-skin.version>1.5</maven-stylus-skin.version>
<maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version>
<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
+ <maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version>
Review Comment:
Got.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] cody195 commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
cody195 commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1210094884
Right, many modules are missing from the original package structure. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1210109510
> @leo65535 , thanks for the update. If the fileSet commented out are not useful. Let's remove them in the next pull request.
>
> +1 The change looks good.
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941916263
##########
ratis-assembly/src/main/assembly/examples-bin.xml:
##########
@@ -68,12 +68,12 @@
<fileMode>755</fileMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
Review Comment:
hi @szetszwo, the `dev-support` should be put in source pkg. http://archive.apache.org/dist/ratis/2.3.0/apache-ratis-2.3.0-src.tar.gz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r940894649
##########
ratis-assembly/src/main/assembly/pkg.xml:
##########
@@ -0,0 +1,28 @@
+<?xml version="1.0"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+-->
+<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
+ <id>pkg</id>
Review Comment:
Let's call it `bin-pkg`.
##########
pom.xml:
##########
@@ -176,6 +176,7 @@
<maven-stylus-skin.version>1.5</maven-stylus-skin.version>
<maven-surefire-plugin.version>3.0.0-M1</maven-surefire-plugin.version>
<maven-checkstyle-plugin.version>3.1.2</maven-checkstyle-plugin.version>
+ <maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version>
Review Comment:
Let's update apache pom version to 27 (the latest) and use the inherited version (i.e. 3.4.1) of `maven-assembly-plugin`.
```
+++ b/pom.xml
@@ -18,7 +18,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
- <version>23</version>
+ <version>27</version>
<relativePath /> <!-- resolve from repository -->
</parent>
```
##########
ratis-assembly/pom.xml:
##########
@@ -123,14 +124,42 @@
<skipAssembly>false</skipAssembly>
<appendAssemblyId>true</appendAssemblyId>
<tarLongFileMode>gnu</tarLongFileMode>
- <descriptors>
- <descriptor>src/main/assembly/src.xml</descriptor>
- <descriptor>src/main/assembly/bin.xml</descriptor>
- <descriptor>src/main/assembly/examples-bin.xml</descriptor>
- <descriptor>src/main/assembly/shell-bin.xml</descriptor>
- </descriptors>
</configuration>
+ <executions>
+ <execution>
+ <id>src</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <descriptors>
+ <descriptor>src/main/assembly/src.xml</descriptor>
+ </descriptors>
+ <finalName>apache-ratis-${project.version}-src</finalName>
+ <appendAssemblyId>false</appendAssemblyId>
+ </configuration>
+ </execution>
+ <execution>
+ <id>default-cli</id>
Review Comment:
Let's use `bin` instead of `default-cli`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1208952766
> @leo65535 , thanks a lot for working on this! The change does work.
> I believe their contents are mostly the same. Is there a way to combine them?
You are right, but I don't have a good idea to combine them, because the example is a complete and independent package structure.
How about exclude the `example` folder currently? like before. http://archive.apache.org/dist/ratis/2.3.0/apache-ratis-2.3.0-bin.tar.gz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on a diff in pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on code in PR #705:
URL: https://github.com/apache/ratis/pull/705#discussion_r941916263
##########
ratis-assembly/src/main/assembly/examples-bin.xml:
##########
@@ -68,12 +68,12 @@
<fileMode>755</fileMode>
</fileSet>
<!-- Include dev support tools -->
- <fileSet>
- <directory>${project.basedir}/../dev-support</directory>
- <outputDirectory>dev-support</outputDirectory>
- <fileMode>0644</fileMode>
- <directoryMode>0755</directoryMode>
- </fileSet>
+<!-- <fileSet>-->
+<!-- <directory>${project.basedir}/../dev-support</directory>-->
+<!-- <outputDirectory>dev-support</outputDirectory>-->
+<!-- <fileMode>0644</fileMode>-->
+<!-- <directoryMode>0755</directoryMode>-->
+<!-- </fileSet>-->
Review Comment:
hi @szetszwo, the `dev-support` should be put in source pkg. http://archive.apache.org/dist/ratis/2.3.0/apache-ratis-2.3.0-src.tar.gz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] leo65535 commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
leo65535 commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1210036621
> Sure, let's exclude the example folder here and fix it in RATIS-1667. Thanks.
Will continue trying to resolve it. Thanks for the suggestion, patch is updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] cody195 commented on pull request #705: RATIS-1660. Fix wrong ratis package
Posted by GitBox <gi...@apache.org>.
cody195 commented on PR #705:
URL: https://github.com/apache/ratis/pull/705#issuecomment-1210108277
> @leo65535 , thanks for the update. If the fileSet commented out are not useful. Let's remove them in the next pull request.
>
> +1 The change looks good.
Got, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org