[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI option to override vpnkit socket

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI option to override vpnkit socket
URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r395964124
 
 

 ##########
 File path: arch/sim/src/sim/up_head.c
 ##########
 @@ -77,6 +78,8 @@ static char g_logbuffer[4096];
 
 int main(int argc, char **argv, char **envp)
 {
+  process_cli_options(argc, argv);
 
 Review comment:
   How about we just save argc and argv in some global variable? Then each component could invoke getopt to parse the argument who is interesting. The advantage is that:
   1.Don't need expose the component internal detail to the world
   2.Don't need modify the common code to add the new option

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services