You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/10 06:57:06 UTC
[GitHub] [dubbo-go-samples] cjphaha opened a new pull request #240: Ftr: add logger sample & readme
cjphaha opened a new pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240
* 添加 logger 打印到控制台， 设置日志隔离级别及输出到文件样例
* 补充readme
* 添加 .run.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] xavier-niu commented on a change in pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#discussion_r706083404
##########
File path: logger/level/conf/dubbogo.yml
##########
@@ -0,0 +1,17 @@
+dubbo:
+ registries:
+ demoZK:
+ protocol: zookeeper
+ timeout: 3s
+ address: 127.0.0.1:2181
+ protocols:
+ triple:
+ name: tri
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
Review comment:
same above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] xavier-niu commented on a change in pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#discussion_r706083257
##########
File path: logger/default/conf/dubbogo.yml
##########
@@ -0,0 +1,17 @@
+dubbo:
+ registries:
+ demoZK:
+ protocol: zookeeper
+ timeout: 3s
+ address: 127.0.0.1:2181
+ protocols:
+ triple:
+ name: tri
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
Review comment:
The quotation should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin edited a comment on pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin edited a comment on pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#issuecomment-916710824
我说怎么你的CI可以通过，manual dog head. @cjphaha
https://github.com/cjphaha/dubbo-go-samples/blob/config-enhance-logger/start_integrate_test.sh#L93
等我修了现在的问题，你把集成测试放开，再合并这个pr吧。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin commented on pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#issuecomment-916710824
我说怎么你的CI可以通过，manual dog head]
https://github.com/cjphaha/dubbo-go-samples/blob/config-enhance-logger/start_integrate_test.sh#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] xavier-niu commented on a change in pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#discussion_r706082652
##########
File path: logger/README.md
##########
@@ -2,9 +2,58 @@
The samples demonstrate how to configure dubbo-go logger using lumberjack
-### Configuration
+### Ccontents
Review comment:
double c?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] cjphaha commented on a change in pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#discussion_r706096024
##########
File path: logger/level/conf/dubbogo.yml
##########
@@ -0,0 +1,17 @@
+dubbo:
+ registries:
+ demoZK:
+ protocol: zookeeper
+ timeout: 3s
+ address: 127.0.0.1:2181
+ protocols:
+ triple:
+ name: tri
+ port: 20000
+ provider:
+ registry:
+ - demoZK
+ services:
+ "greeterImpl":
Review comment:
thx！ i have fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin edited a comment on pull request #240: Ftr: add logger sample & readme
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin edited a comment on pull request #240:
URL: https://github.com/apache/dubbo-go-samples/pull/240#issuecomment-916710824
我说怎么你的CI可以通过，manual dog head. @cjphaha
https://github.com/cjphaha/dubbo-go-samples/blob/config-enhance-logger/start_integrate_test.sh#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org