You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2010/09/08 21:39:08 UTC
[Bug 6488] New: Lint errors with Perl 5.12.1
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
Summary: Lint errors with Perl 5.12.1
Product: Spamassassin
Version: 3.3.1
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: rosenbaumlm@ornl.gov
When running SA v3.3.1 on Linux with perl 5.12.1, I get the following lint
errors:
Sep 8 15:23:44.322 [21388] warn: Use of "goto" to jump into a construct is
deprecated at /opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/Check.pm
line 409.
Sep 8 15:23:45.242 [21388] warn: Use of uninitialized value in lc at
/opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm line 501.
Sep 8 15:23:45.248 [21388] warn: Use of uninitialized value $name in lc at
/opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/AntiVirus.pm line 101.
Sep 8 15:23:45.248 [21388] warn: Use of uninitialized value in lc at
/opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/AntiVirus.pm line 103.
The 'Use of "goto" line appears several times. Also, there is a warning about
defined(%hash), but that has already been reported.
SpamAssassin version 3.3.1
running on Perl version 5.12.1
Linux ornlspam01.ornl.gov 2.6.18-194.11.1.el5 #1 SMP Tue Jul 27 05:45:06 EDT
2010 x86_64 x86_64 x86_64 GNU/Linux
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #8 from Mark Martinec <Ma...@ijs.si> 2010-10-27 20:47:47 UTC ---
Created an attachment (id=4818)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4818)
the diff (for reference)
the committed diff
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #6 from Karsten Bräckelmann <gu...@rudersport.de> 2010-10-27 20:22:39 UTC ---
Oh, come on. This is a bug tracker, not a forum. If you need help or
assistance, please tend to the users mailing list.
The fix to this bug should be pretty much the same as revision 929343, the fix
for "Use of uninitialized value in lc" in bug 6396, as referred to in comment
1.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] [review] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P2 |P3
Target Milestone|Undefined |3.3.2
Summary|Lint errors with Perl |[review] Lint errors with
|5.12.1 in AntiVirus.pm |Perl 5.12.1 in AntiVirus.pm
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] [review] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |kmcgrail@pccc.com
Resolution| |FIXED
Status Whiteboard| |ready to commit
--- Comment #10 from Kevin A. McGrail <km...@pccc.com> 2010-10-28 09:19:06 UTC ---
(In reply to comment #9)
>
> +1 after code review, without testing it
+1 here as well for any and all purposes also without testing beyond a
compilation validity. I believe with votes from Mark (implied), Karsten and
myself, that's a ready to commit.
KAM
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #3 from Joan <jo...@grosjo.net> 2010-10-20 20:33:25 UTC ---
Note : Using perl 5.12.2 on LInux 2.6.34.6 - 64bits (AMD)
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2010-10-27 20:43:50 UTC ---
> The fix to this bug should be pretty much the same as revision 929343, the fix
> for "Use of uninitialized value in lc" in bug 6396, as referred to in comment
> 1.
trunk:
Bug 6488 - Lint errors with Perl 5.12.1 in AntiVirus.pm
Sending lib/Mail/SpamAssassin/Plugin/AntiVirus.pm
Committed revision 1028149.
3.3 (trivial I suppose)
Bug 6488 - Lint errors with Perl 5.12.1 in AntiVirus.pm
Sending lib/Mail/SpamAssassin/Plugin/AntiVirus.pm
Committed revision 1028151.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] [review] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #9 from Karsten Bräckelmann <gu...@rudersport.de> 2010-10-27 21:38:16 UTC ---
(In reply to comment #7)
> > The fix to this bug should be pretty much the same as revision 929343, the fix
> > for "Use of uninitialized value in lc" in bug 6396, as referred to in comment
> > 1.
> 3.3 (trivial I suppose)
> Bug 6488 - Lint errors with Perl 5.12.1 in AntiVirus.pm
> Sending lib/Mail/SpamAssassin/Plugin/AntiVirus.pm
> Committed revision 1028151.
Thanks, Mark. :) It was just too late for me to hit svn, especially with code
I cannot possibly test, since I do not use it. Anyway...
+1 after code review, without testing it
And yes, I agree, probably trivial just as bug 6396 comment 1.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #5 from Joan <jo...@grosjo.net> 2010-10-27 20:11:06 UTC ---
What to do to fix this ?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Lint errors with Perl |Lint errors with Perl
|5.12.1 |5.12.1 in AntiVirus.pm
--- Comment #1 from Karsten Bräckelmann <gu...@rudersport.de> 2010-09-08 17:05:17 UTC ---
> Sep 8 15:23:44.322 [21388] warn: Use of "goto" to jump into a construct is
> deprecated at /opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/Check.pm
> line 409.
Bug 6392, fixed in trunk and 3.3 branch.
> Sep 8 15:23:45.242 [21388] warn: Use of uninitialized value in lc at
> /opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm line 501.
Bug 6396, fixed in trunk and 3.3 branch.
> Sep 8 15:23:45.248 [21388] warn: Use of uninitialized value $name in lc at
> /opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/AntiVirus.pm line 101.
> Sep 8 15:23:45.248 [21388] warn: Use of uninitialized value in lc at
> /opt/ActivePerl-5.12/site/lib/Mail/SpamAssassin/Plugin/AntiVirus.pm line 103.
This appears to be un-reported so far.
> The 'Use of "goto" line appears several times. Also, there is a warning about
> defined(%hash), but that has already been reported.
Indeed, bug 6392 again.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] [review] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
Karsten Bräckelmann <gu...@rudersport.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |me@junc.eu
--- Comment #11 from Karsten Bräckelmann <gu...@rudersport.de> ---
*** Bug 6941 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
--- Comment #4 from Karsten Bräckelmann <gu...@rudersport.de> 2010-10-27 20:05:21 UTC ---
*** Bug 6502 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6488] Lint errors with Perl 5.12.1 in AntiVirus.pm
Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6488
Joan <jo...@grosjo.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jom@grosjo.net
--- Comment #2 from Joan <jo...@grosjo.net> 2010-10-20 20:32:07 UTC ---
I have the same exact error with the SVN of today (Oct 20, 2010):
Oct 21 03:31:05 master spamd[8214]: Use of uninitialized value $name in lc at
/usr/lib/perl5/site_perl/5.12.2/Mail/SpamAssassin/Plugin/AntiVirus.pm line 101.
Oct 21 03:31:05 master spamd[8214]: Use of uninitialized value in lc at
/usr/lib/perl5/site_perl/5.12.2/Mail/SpamAssassin/Plugin/AntiVirus.pm line 103.
Oct 21 03:31:05 master spamd[8214]: Use of uninitialized value $name in lc at
/usr/lib/perl5/site_perl/5.12.2/Mail/SpamAssassin/Plugin/AntiVirus.pm line 101.
Oct 21 03:31:05 master spamd[8214]: Use of uninitialized value in lc at
/usr/lib/perl5/site_perl/5.12.2/Mail/SpamAssassin/Plugin/AntiVirus.pm line 103.
Oct 21 03:31:05 master spamd[8214]: Use of uninitialized value $name in lc at
/usr/lib/perl5/site_perl/5.12.2/Mail/SpamAssassin/Plugin/AntiVirus.pm line 101.
Oct 21 03:31:05 master spamd[8214]: Use of uninitialized value in lc at
/usr/lib/perl5/site_perl/5.12.2/Mail/SpamAssassin/Plugin/AntiVirus.pm line 103.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.