You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/03 19:39:14 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6873: feature/#6766 JSON and Startree index information in API
Jackie-Jiang commented on a change in pull request #6873:
URL: https://github.com/apache/incubator-pinot/pull/6873#discussion_r625320057
##########
File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/SegmentMetadataFetcher.java
##########
@@ -63,9 +77,67 @@ public static String getSegmentMetadata(SegmentDataManager segmentDataManager, L
}
ObjectNode segmentMetadataJson = (ObjectNode) segmentMetadata.toJson(columnSet);
segmentMetadataJson.set("indexes", JsonUtils.objectToJsonNode(getIndexesForSegmentColumns(segmentDataManager)));
+ segmentMetadataJson.set(STAR_TREE_INDEX_KEY, JsonUtils.objectToJsonNode((getStartreeIndexForSegmentColumns(segmentDataManager))));
return JsonUtils.objectToString(segmentMetadataJson);
}
+ /**
+ * Get the JSON object containing star tree index details for a segment.
+ */
+ private static List<Map<String, Object>> getStartreeIndexForSegmentColumns(SegmentDataManager segmentDataManager) {
+ List<Map<String, Object>> startreeDetails = new ArrayList<>();
+
+ if (segmentDataManager instanceof ImmutableSegmentDataManager) {
+ ImmutableSegmentDataManager immutableSegmentDataManager = (ImmutableSegmentDataManager) segmentDataManager;
+
+ ImmutableSegment immutableSegment = immutableSegmentDataManager.getSegment();
+
+ if (immutableSegment instanceof ImmutableSegmentImpl) {
+ List<StarTreeV2> starTrees = immutableSegment.getStarTrees();
+
+ if (starTrees == null) {
+ return startreeDetails;
+ }
+
+ startreeDetails = getImmutableSegmentStartreeIndexes(starTrees);
+ }
+ }
+ return startreeDetails;
+ }
+
+ /**
+ * Helper to loop over star trees of a segment to create a map containing star tree details.
+ */
+ private static List<Map<String, Object>> getImmutableSegmentStartreeIndexes(List<StarTreeV2> starTrees){
+ List<Map<String, Object>> startreeDetails = new ArrayList<>();
+ for (StarTreeV2 starTree : starTrees) {
+ StarTreeV2Metadata starTreeMetadata = starTree.getMetadata();
+
+ Map<String, Object> starTreeIndexMap = new LinkedHashMap<>();
+
+ List<String> starTreeDimensions = starTreeMetadata.getDimensionsSplitOrder();
+ starTreeIndexMap.put(STAR_TREE_DIMENSION_COLUMNS, starTreeDimensions);
+
+ List<Map<String, String>> starTreeMetricAggregations = new ArrayList<>();
+ Set<AggregationFunctionColumnPair> functionColumnPairs = starTreeMetadata.getFunctionColumnPairs();
+ for (AggregationFunctionColumnPair functionColumnPair : functionColumnPairs) {
Review comment:
Directly put it as a list of `functionColumnPair.toColumnName()`, no need to create a separate map
##########
File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/SegmentMetadataFetcher.java
##########
@@ -63,9 +77,67 @@ public static String getSegmentMetadata(SegmentDataManager segmentDataManager, L
}
ObjectNode segmentMetadataJson = (ObjectNode) segmentMetadata.toJson(columnSet);
segmentMetadataJson.set("indexes", JsonUtils.objectToJsonNode(getIndexesForSegmentColumns(segmentDataManager)));
+ segmentMetadataJson.set(STAR_TREE_INDEX_KEY, JsonUtils.objectToJsonNode((getStartreeIndexForSegmentColumns(segmentDataManager))));
return JsonUtils.objectToString(segmentMetadataJson);
}
+ /**
+ * Get the JSON object containing star tree index details for a segment.
+ */
+ private static List<Map<String, Object>> getStartreeIndexForSegmentColumns(SegmentDataManager segmentDataManager) {
+ List<Map<String, Object>> startreeDetails = new ArrayList<>();
+
+ if (segmentDataManager instanceof ImmutableSegmentDataManager) {
Review comment:
We don't need these `instanceof` checks. The method is declared in the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org