You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by aw...@apache.org on 2018/06/18 16:52:43 UTC

cassandra git commit: fqltool should open chronicle queue read only and a GC bug

Repository: cassandra
Updated Branches:
  refs/heads/trunk 717c10837 -> c6570fac1


fqltool should open chronicle queue read only and a GC bug

Patch by Ariel Weisberg; Reviewed by Sam Tunnicliffe for CASSANDRA-14504


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c6570fac
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c6570fac
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c6570fac

Branch: refs/heads/trunk
Commit: c6570fac180b6f816efb47cbd9b7fe30c771835d
Parents: 717c108
Author: Ariel Weisberg <aw...@apple.com>
Authored: Thu Jun 7 14:22:43 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Mon Jun 18 12:35:06 2018 -0400

----------------------------------------------------------------------
 src/java/org/apache/cassandra/tools/fqltool/Dump.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c6570fac/src/java/org/apache/cassandra/tools/fqltool/Dump.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/tools/fqltool/Dump.java b/src/java/org/apache/cassandra/tools/fqltool/Dump.java
index 6a748bc..52eadb5 100644
--- a/src/java/org/apache/cassandra/tools/fqltool/Dump.java
+++ b/src/java/org/apache/cassandra/tools/fqltool/Dump.java
@@ -81,7 +81,7 @@ public class Dump implements Runnable
             {
                 int protocolVersion = wireIn.read("protocol-version").int32();
                 sb.append("Protocol version: ").append(protocolVersion).append(System.lineSeparator());
-                QueryOptions options = QueryOptions.codec.decode(Unpooled.wrappedBuffer(wireIn.read("query-options").bytesStore().toTemporaryDirectByteBuffer()), ProtocolVersion.decode(protocolVersion));
+                QueryOptions options = QueryOptions.codec.decode(Unpooled.wrappedBuffer(wireIn.read("query-options").bytes()), ProtocolVersion.decode(protocolVersion));
                 sb.append("Query time: ").append(wireIn.read("query-time").int64()).append(System.lineSeparator());
 
                 if (type.equals("single"))
@@ -126,7 +126,7 @@ public class Dump implements Runnable
 
         //Backoff strategy for spinning on the queue, not aggressive at all as this doesn't need to be low latency
         Pauser pauser = Pauser.millis(100);
-        List<ChronicleQueue> queues = arguments.stream().distinct().map(path -> ChronicleQueueBuilder.single(new File(path)).rollCycle(RollCycles.valueOf(rollCycle)).build()).collect(Collectors.toList());
+        List<ChronicleQueue> queues = arguments.stream().distinct().map(path -> ChronicleQueueBuilder.single(new File(path)).readOnly(true).rollCycle(RollCycles.valueOf(rollCycle)).build()).collect(Collectors.toList());
         List<ExcerptTailer> tailers = queues.stream().map(ChronicleQueue::createTailer).collect(Collectors.toList());
         boolean hadWork = true;
         while (hadWork)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org