You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/14 12:16:34 UTC

[GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins

twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217369978
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -155,6 +156,50 @@ class Table(
     select(withResolvedAggFunctionCall: _*)
   }
 
+  /**
+    * Creates [[TemporalTableFunction]] backed up by this table as a history table.
+    *
+    * @param timeIndicator field for the [[TemporalTableFunction]]. Must points to a time indicator
+    * @param primaryKey    field for the [[TemporalTableFunction]].
+    * @return [[TemporalTableFunction]]
 
 Review comment:
   Add documentation what users can do with this return value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services