[jira] [Commented] (HBASE-18568) Correct metric of numRegions

["huaxiang sun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181792#comment-16181792 ] 

huaxiang sun commented on HBASE-18568:
--------------------------------------

[~psomogyi] and I are debugging one memory leak regarding with region open/close. We traced back to metrics are held in this Aggregate data structure. I think this needs to go into 1.2 and 1.3 as well.

> Correct  metric of  numRegions
> ------------------------------
>
>                 Key: HBASE-18568
>                 URL: https://issues.apache.org/jira/browse/HBASE-18568
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 3.0.0
>            Reporter: Shibin Zhang
>            Assignee: Shibin Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-18568-V1.patch
>
>
> i found the value of  metric numReigons in Regions is not correct.
> the metric can not add or remove  region correctly as region  close or open.
> the metric  as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in MetricsRegionSourceImpl#MetricsRegionSourceImpl 
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet initialized.
> So, the setFromMap can not put or remove the object correctly. 
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)