[jira] [Commented] (AURORA-84) Deprecate the Identity struct

["Suman Karumuri (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990183#comment-13990183 ] 

Suman Karumuri commented on AURORA-84:
--------------------------------------

[~wfarner] There are 2 uses of this struct in TaskConfig and TaskQuery. 

a) In TaskConfig, I think we should replace owner, environment and jobName fields with JobKey.

b) For TaskQuery, we can drop the owner field entirely. However, we will loose the ability to query all tasks by owned by a role and launched by a user. The simplest way forward seems to be add a user field to TaskQuery struct and remove the owner field. 

Does that sound like a good way forward?

> Deprecate the Identity struct
> -----------------------------
>
>                 Key: AURORA-84
>                 URL: https://issues.apache.org/jira/browse/AURORA-84
>             Project: Aurora
>          Issue Type: Task
>          Components: Client, Scheduler
>            Reporter: Bill Farner
>
> The Identity field is nested in several structs, and the {{role}} field it contains is ~always redundant to a field in {{JobKey}}. Consider removing Identity and using (or adding) a non-user-bearing field like JobKey.
> An open question is whether whether {{Identity.user}} should be retained.  Most likely yes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)