[GitHub] [solr] HoustonPutman commented on pull request #564: SOLR-15954: Move the Prometheus Exporter from modules

[GitBox <gi...@apache.org>]

HoustonPutman commented on pull request #564:
URL: https://github.com/apache/solr/pull/564#issuecomment-1021322512


   > I was going to builda Docker image from the binary distro to test the exporter from docker, but looking in docker/ folder in binary distro, there is no description on how to build the image. No description in main README.md either. I think there is one in the ref.guide, but should there not be a docker/README.md with a sample command?
   
   I think this is a good point, but kind of separate from this ticket. I'll create a JIRA and do that separately. 
   
   > Nowhere does it echo the port it was started on in the default case. Would be nice if the log said `Started the exporter on port NNNN` so folks trying it the first time will at least easily find it in browser.
   
   Again good point, but will fix separately.
   
   > PS: The link to ref-guide in solr-exporter/README.md is broken link. Should be https://solr.apache.org/guide/8_11/monitoring-solr-with-prometheus-and-grafana.html, not https://solr.apache.org/guide/monitoring-with-prometheus-and-grafana.html as it is now.
   
   This is the name of the page starting with 9.0, so I agree that it isn't great that the link is broken until 9.0 is released. However, given that it will be released relatively soon, I think we can keep the future-proof URL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org