[jira] [Commented] (BEAM-2581) KinesisClientProvider interface needs to be public

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16146307#comment-16146307 ] 

ASF GitHub Bot commented on BEAM-2581:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3540


> KinesisClientProvider interface needs to be public
> --------------------------------------------------
>
>                 Key: BEAM-2581
>                 URL: https://issues.apache.org/jira/browse/BEAM-2581
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>    Affects Versions: 2.0.0
>            Reporter: Nawaid Shamim
>            Assignee: Chamikara Jayalath
>            Priority: Minor
>
> Using Beam to read from kinesis stream. _KinesisIO_ provides two overloaded methods - _withClientProvider_ to provide AWS credentials or implement an interface - _KinesisClientProvider_  to pass _AWSKinesisClient_ as described on [here|https://beam.apache.org/documentation/sdks/javadoc/2.0.0/]
> {code}
> There's also possibility to start reading using arbitrary point in time - in this case you need to provide Instant object:
>  p.apply(KinesisIO.read()
>      .from("streamName", instant)
>      .withClientProvider(new KinesisClientProvider() {
>                         @Override
>                         public AmazonKinesis get() {
>                             return null;
>                         }
>       })
>   .apply( ... ) // other transformations
> {code}
> The above code requires org.apache.beam.sdk.io.kinesis.KinesisClientProvider interface to be public.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)