You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/17 08:05:31 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #2071: [CALCITE-4127] Remove final from AbstractRelNode#getRelTypeName

danny0405 commented on a change in pull request #2071:
URL: https://github.com/apache/calcite/pull/2071#discussion_r456285940



##########
File path: core/src/main/java/org/apache/calcite/rel/AbstractRelNode.java
##########
@@ -177,7 +177,8 @@ public void register(RelOptPlanner planner) {
     Util.discard(planner);
   }
 
-  public final String getRelTypeName() {
+  // It is not recommended to override this method, but sub-classes can do it at their own risk.
+  public String getRelTypeName() {

Review comment:
       It would be cool if we can also describe a little what the original purpose of this method too ~




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org