You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan Ernst (JIRA)" <ji...@apache.org> on 2016/03/08 04:04:40 UTC
[jira] [Commented] (LUCENE-7077) fail precommit on useless
assignment
[ https://issues.apache.org/jira/browse/LUCENE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184296#comment-15184296 ]
Ryan Ernst commented on LUCENE-7077:
------------------------------------
+1
> fail precommit on useless assignment
> ------------------------------------
>
> Key: LUCENE-7077
> URL: https://issues.apache.org/jira/browse/LUCENE-7077
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-7077.patch
>
>
> I found LUCENE-7073 because of a compiler warning in my IDE. It slipped all the way through buggy tests too! I think we should fail when "assignment has no effect", rather than just rely on someone to catch it visually.
> This is very specific and will not trigger a bunch of false positives: but can indicate a common bug in e.g. constructors for POJO classes and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (LUCENE-7077) fail precommit on useless assignment
Posted by Erick Erickson <er...@gmail.com>.
Absolutely.
On Mon, Mar 7, 2016 at 7:04 PM, Ryan Ernst (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184296#comment-15184296 ]
>
> Ryan Ernst commented on LUCENE-7077:
> ------------------------------------
>
> +1
>
>> fail precommit on useless assignment
>> ------------------------------------
>>
>> Key: LUCENE-7077
>> URL: https://issues.apache.org/jira/browse/LUCENE-7077
>> Project: Lucene - Core
>> Issue Type: Bug
>> Reporter: Robert Muir
>> Attachments: LUCENE-7077.patch
>>
>>
>> I found LUCENE-7073 because of a compiler warning in my IDE. It slipped all the way through buggy tests too! I think we should fail when "assignment has no effect", rather than just rely on someone to catch it visually.
>> This is very specific and will not trigger a bunch of false positives: but can indicate a common bug in e.g. constructors for POJO classes and so on.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org