You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/11/16 18:04:58 UTC
Review Request 40353: Kafka's metrics are not displayed on cluster
installed via blueprints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40353/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, John Speidel, and Vitalyi Brodetskyi.
Bugs: AMBARI-13908
https://issues.apache.org/jira/browse/AMBARI-13908
Repository: ambari
Description
-------
Steps:
1. Deploy cluster with custom log/pid directories.
2. Go to Kafka page.
Result: no metrics are present ("No Data Available").
Was reproduced twice.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9e2bf85
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 1020f6a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 1e75dbf
Diff: https://reviews.apache.org/r/40353/diff/
Testing
-------
Unit tests passed
+ manual deployments
Thanks,
Dmytro Sen
Re: Review Request 40353: Kafka's metrics are not displayed on cluster
installed via blueprints
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40353/#review106692
-----------------------------------------------------------
Ship it!
Patch looks fine overall, just a few minor issues to resolve.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 2250)
<https://reviews.apache.org/r/40353/#comment165426>
Minor issue:
I'd recommend making this variable "final", since this value should be a constant.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 2283)
<https://reviews.apache.org/r/40353/#comment165427>
Minor issue:
As in the comment above, I'd recommend making this variable "final", to make sure the compiler enforces this invariant.
- Robert Nettleton
On Nov. 16, 2015, 5:04 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40353/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 5:04 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, John Speidel, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-13908
> https://issues.apache.org/jira/browse/AMBARI-13908
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
> 1. Deploy cluster with custom log/pid directories.
> 2. Go to Kafka page.
> Result: no metrics are present ("No Data Available").
> Was reproduced twice.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9e2bf85
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 1020f6a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 1e75dbf
>
> Diff: https://reviews.apache.org/r/40353/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
> + manual deployments
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 40353: Kafka's metrics are not displayed on cluster
installed via blueprints
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40353/
-----------------------------------------------------------
(Updated Ноя. 16, 2015, 6:34 п.п.)
Review request for Ambari, Andrew Onischuk, John Speidel, and Vitalyi Brodetskyi.
Bugs: AMBARI-13908
https://issues.apache.org/jira/browse/AMBARI-13908
Repository: ambari
Description
-------
Steps:
1. Deploy cluster with custom log/pid directories.
2. Go to Kafka page.
Result: no metrics are present ("No Data Available").
Was reproduced twice.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java 9e2bf85
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml 1020f6a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 2b55ffb
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 6645083
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 1e75dbf
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py cd61cba
Diff: https://reviews.apache.org/r/40353/diff/
Testing
-------
Unit tests passed
+ manual deployments
Thanks,
Dmytro Sen