[GitHub] [metamodel] kaspersorensen commented on a change in pull request #218: Use Scan.addColumn(...) instead of Scan.addFamily(...) when has qualifier.

[GitBox <gi...@apache.org>]

kaspersorensen commented on a change in pull request #218: Use Scan.addColumn(...) instead  of Scan.addFamily(...) when has qualifier.
URL: https://github.com/apache/metamodel/pull/218#discussion_r273257498
 
 

 ##########
 File path: hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java
 ##########
 @@ -222,9 +222,11 @@ protected DataSet materializeMainSchemaTable(Table table, List<Column> columns,
         for (Column column : columns) {
             if (!column.isPrimaryKey()) {
                 final int colonIndex = column.getName().indexOf(':');
+                final int len = column.getName().length();
                 if (colonIndex != -1) {
                     String family = column.getName().substring(0, colonIndex);
-                    scan.addFamily(family.getBytes());
+                    String colName = column.getName().substring(colonIndex + 1, len);
 
 Review comment:
   Remember to add `final` :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services