You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/12/26 04:02:40 UTC
[PR] GH-48662: [R] Remove trace$calls %||% trace$call once rlang > 0.4.11 is released [arrow]
HyukjinKwon opened a new pull request, #48663:
URL: https://github.com/apache/arrow/pull/48663
### Rationale for this change
https://github.com/apache/arrow/blob/ff5572c845118c6228a896ef9223e81f660cda66/r/R/metadata.R#L75
https://github.com/apache/arrow/blob/ff5572c845118c6228a896ef9223e81f660cda66/r/R/metadata.R#L148
rlang changed its callstack API: older versions used trace$call (singular), newer versions (rlang 0.4.11+) use trace$calls (plural) from https://github.com/r-lib/rlang/pull/1255
This was released 5 years ago so should be safe to remove this workaround.
### What changes are included in this PR?
This PR removes `trace$call` workaround (per newer `trace$calls`).
### Are these changes tested?
Existing CI should cover this.
### Are there any user-facing changes?
No, dev-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48662: [R] Remove trace$calls %||% trace$call once rlang > 0.4.11 is released [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48663:
URL: https://github.com/apache/arrow/pull/48663#issuecomment-3694390071
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 16743102624c1425e46e99bca6f6ffac0ad64ffe.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/59020348071) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48662: [R] Remove trace$calls %||% trace$call once rlang > 0.4.11 is released [arrow]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48663:
URL: https://github.com/apache/arrow/pull/48663#issuecomment-3694228935
Thank you @jonkeane !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48662: [R] Remove trace$calls %||% trace$call once rlang > 0.4.11 is released [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane merged PR #48663:
URL: https://github.com/apache/arrow/pull/48663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48662: [R] Remove trace$calls %||% trace$call once rlang > 0.4.11 is released [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48663:
URL: https://github.com/apache/arrow/pull/48663#issuecomment-3692039720
:warning: GitHub issue #48662 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org