[GitHub] aaronmarkham commented on a change in pull request #13544: turn on Sphinx warnings as errors

[GitBox <gi...@apache.org>]

aaronmarkham commented on a change in pull request #13544: turn on Sphinx warnings as errors
URL: https://github.com/apache/incubator-mxnet/pull/13544#discussion_r239331752
 
 

 ##########
 File path: docs/build_version_doc/build_all_version.sh
 ##########
 @@ -117,6 +120,8 @@ function checkout () {
   git checkout "$repo_folder" || git branch $repo_folder "upstream/$repo_folder" && git checkout "$repo_folder" || exit 1
   if [ $tag == 'master' ]; then
     git pull
+    # master gets warnings as errors for Sphinx builds
 
 Review comment:
   I added the `-W` option to the new docs pipeline. This should force it to happen any time that runs. And the website build flow will still skip it for old versions. I'm not totally familiar with new pipelines, so please let me know if you think this is going to be an issue or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services