[jira] [Commented] (HBASE-16833) Implement asynchronous hbase client based on HBASE-15921

["Phil Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729260#comment-15729260 ] 

Phil Yang commented on HBASE-16833:
-----------------------------------

Skimmed the current code. Not fully follow your work on async client, pardon me if I miss something.

{code:title=AsyncTableRegionLocatorImpl.java}
@Override
  public CompletableFuture<HRegionLocation> getRegionLocation(byte[] row, boolean reload) {
    return locator.getRegionLocation(tableName, row, 0L);
  }
{code}
We should consider the reload parameter? And for region caching, if we need to reload the region info from meta, we may have some concurrent requests for same table even same region. We could let the first one send the RPC request and the others wait the result?

{code}
private static final long SLEEP_DELTA_NS = TimeUnit.MILLISECONDS.toNanos(1);
{code}
I think for sync client we also have this issue, may be we should add it also in sync client and make it configurable?



> Implement asynchronous hbase client based on HBASE-15921
> --------------------------------------------------------
>
>                 Key: HBASE-16833
>                 URL: https://issues.apache.org/jira/browse/HBASE-16833
>             Project: HBase
>          Issue Type: Umbrella
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>              Labels: asynchronous
>             Fix For: 2.0.0
>
>
> In HBASE-15921 we have introduced a simple AsyncTable only supports get, put and delete. This issue aims to implement a complete async hbase client based on it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)