You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 17:05:25 UTC
[GitHub] [flink-statefun] abc863377 opened a new pull request #106: Stateful Functions Examples have their specific job names
abc863377 opened a new pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106
Greeter-example
Python-greeter-example
Python-kubernetes-example
Ridesharing-example
Shopping-cart-example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] sjwiesman closed pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman edited a comment on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
igalshilman edited a comment on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-628613062
Hi @abc863377, I think that there is a consensus not to proceed with the change here, but I'd like to suggest the following: can you set the `statefun.flink-job-name` key at `tools/docker/flink-distribution-template/conf/flink-conf.yaml` so that people who would like to change the job name, would know what to modify.
The suggest change is to add:
```
statefun.flink-job-name: Statefun Application
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] sjwiesman commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-631677707
Merging . . .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
igalshilman commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-626631060
Hi there,
Thanks a lot for opening your first PR for this project, and welcome :-)
I think that everything we will put in the examples folks would accidentally think that this is mandatory and copy to their projects.
I’d really like the Dockerfile to stay as simple as possible at this moment, to lower the entrance barrier for StateFun.
Did you find the lack of a specific job name confusing for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] tzulitai commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-628386637
I originally opened FLINK-16985.
I wouldn't say lacking the specific job name is confusing, but maybe rounds up a better user experience for new users who are just coming to this repo for the first time, running the application, and then looking at the Flink Web UI to see what's happening behind the scenes.
But I agree that adding this extra bit to the example Dockerfiles can be a bit distracting from a "introductory examples" point of view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] abc863377 commented on pull request #106: Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
abc863377 commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-625615368
@tzulitai Can you please review it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
igalshilman commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-628613062
Hi @abc863377, I think that there is a consensus, proceed with the change here, but I'd like to suggest the following: can you set the `statefun.flink-job-name` key at `tools/docker/flink-distribution-template/conf/flink-conf.yaml` so that people who would like to change the job name, could know what to modify.
The suggest change is to add:
```
statefun.flink-job-name: Statefun Application
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] abc863377 commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
abc863377 commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-631562660
Hi @igalshilman ,
Thanks for the suggestion. I'll follow your advice and keep Dockerfile simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] abc863377 commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
abc863377 commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-631670413
Hi, @igalshilman ,
Sorry. I am a Git beginner.
Now I removed the old commit. and updated the new statefun.flink-job-name configuration to the distribution template.
Can you please review it?
Thanks a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman edited a comment on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
igalshilman edited a comment on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-628613062
Hi @abc863377, I think that there is a consensus not to proceed with the change here, but I'd like to suggest the following: can you set the `statefun.flink-job-name` key at `tools/docker/flink-distribution-template/conf/flink-conf.yaml` so that people who would like to change the job name, could know what to modify.
The suggest change is to add:
```
statefun.flink-job-name: Statefun Application
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-statefun] igalshilman commented on pull request #106: [FLINK-16985] Stateful Functions Examples have their specific job names
Posted by GitBox <gi...@apache.org>.
igalshilman commented on pull request #106:
URL: https://github.com/apache/flink-statefun/pull/106#issuecomment-631675361
Hi @abc863377,
No worries, thanks a lot for your first contribution to this project!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org