You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/29 11:06:26 UTC
[GitHub] [beam] eantyshev opened a new pull request, #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
eantyshev opened a new pull request, #23419:
URL: https://github.com/apache/beam/pull/23419
We have a convention between Playground and Tour Of Beam that ToB examples and snippets (and files and pc_objects too)
have the following key:
`<origin>_<SDK>_<name>` where
```
origin = "TB_EXAMPLES"
SDK = "SDK_JAVA" | "SDK_PYTHON" | "SDK_GO" | "SDK_SCIO"
name = /beam-playground/name
```
name is from an embedded yaml tag in a code example
duplicated also as taskName or solutionName in `learning-content/.../unit-info.yaml`
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #23419:
URL: https://github.com/apache/beam/pull/23419#issuecomment-1262721733
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] eantyshev commented on a diff in pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
eantyshev commented on code in PR #23419:
URL: https://github.com/apache/beam/pull/23419#discussion_r983606478
##########
learning/tour-of-beam/backend/internal/fs_content/load.go:
##########
@@ -38,50 +38,34 @@ const (
)
type learningPathInfo struct {
- Sdk string
+ Sdk string `yaml:"sdk"`
Content []string `yaml:"content"`
}
type learningModuleInfo struct {
- Id string
- Name string
- Complexity string
+ Id string `yaml:"id"`
+ Name string `yaml:"name"`
+ Complexity string `yaml:"complexity"`
Review Comment:
It worked, but now we set yaml tags to make this code explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #23419:
URL: https://github.com/apache/beam/pull/23419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] eantyshev commented on a diff in pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
eantyshev commented on code in PR #23419:
URL: https://github.com/apache/beam/pull/23419#discussion_r983605097
##########
learning/tour-of-beam/backend/internal/entity.go:
##########
@@ -33,8 +33,6 @@ type Unit struct {
Hints []string `json:"hints,omitempty"`
TaskSnippetId string `json:"taskSnippetId,omitempty"`
SolutionSnippetId string `json:"solutionSnippetId,omitempty"`
- TaskName string `json:"-"`
- SolutionName string `json:"-"`
Review Comment:
clean up the model from intermediate fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] olehborysevych commented on pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
olehborysevych commented on PR #23419:
URL: https://github.com/apache/beam/pull/23419#issuecomment-1265198164
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] eantyshev commented on a diff in pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
eantyshev commented on code in PR #23419:
URL: https://github.com/apache/beam/pull/23419#discussion_r983605097
##########
learning/tour-of-beam/backend/internal/entity.go:
##########
@@ -33,8 +33,6 @@ type Unit struct {
Hints []string `json:"hints,omitempty"`
TaskSnippetId string `json:"taskSnippetId,omitempty"`
SolutionSnippetId string `json:"solutionSnippetId,omitempty"`
- TaskName string `json:"-"`
- SolutionName string `json:"-"`
Review Comment:
clean up the model from temporary fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23419: [Tour Of Beam] return taskSnippetId/solutionSnippedId
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23419:
URL: https://github.com/apache/beam/pull/23419#issuecomment-1265199462
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org