You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/01/30 01:15:37 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19804: [v1.x] Onnx Reshpe support for special caes

Zha0q1 commented on a change in pull request #19804:
URL: https://github.com/apache/incubator-mxnet/pull/19804#discussion_r567172638



##########
File path: python/mxnet/contrib/onnx/mx2onnx/_op_translations.py
##########
@@ -1612,6 +1613,17 @@ def convert_reshape(node, **kwargs):
     reverse = attrs.get('reverse', 'False')
     targ_shape = convert_string_to_list(attrs["shape"])
 
+    # In general -2, -3, -4 in the target shape are not supoorted, but there are
+    # a few special cases that we can convert to supported scenarios
+
+    # If -2 and -4 are not used, then we can just remove the -4

Review comment:
       yes! fixed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org