You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by echarles <gi...@git.apache.org> on 2015/06/28 11:43:34 UTC

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

GitHub user echarles opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/127

    getPort should not have curly bracket in its body

    This patch simply remove the usage of curly bracket in the body of the getPort method of the app.js.
    This is needed so the AppScriptServlet can do its correctly in case of developement in both client and server sides.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echarles/incubator-zeppelin app-js-server-mode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit dfaba556c230fefeca28369e8a3788e2e633b6db
Author: Eric Charles <er...@datalayer.io>
Date:   2015-06-28T09:39:18Z

    getPort should not have curly bracket in its body

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-116357013
  
    Thank you for bringing it in again! 
    Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-116892833
  
    Hi, @echarles 
    
    Can you explain to me exactly what is the relation between the getPort function and the AppScriptServlet? And how they work together?
    
    I'm currently planning on rebasing the #56 PR to master, and in that commit: https://github.com/corneadoug/incubator-zeppelin/commit/bc76301e5ccfcb4316fcb1a7e0d7438e12b68fb2
    
    I made changes to move those functions (getPort, getWebsocketProtocol, getRestApiBase) to their own service, instead of having them inside of app.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-116302183
  
    Thanks! Looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/127#issuecomment-117275060
  
    Because of AppScriptServlet replace `function getPort() {  ... }` by detecting `}`. Please check https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/server/AppScriptServlet.java#L83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: getPort should not have curly bra...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---