You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/07 13:51:04 UTC
[GitHub] [dolphinscheduler-website] QuakeWang opened a new pull request #402: [Summer2021] Translate the registry_spi.md
QuakeWang opened a new pull request #402:
URL: https://github.com/apache/dolphinscheduler-website/pull/402
According to this [document](https://dolphinscheduler.apache.org/zh-cn/docs/dev/user_doc/registry_spi.html), then translated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] CalvinKirs commented on a change in pull request #402: [Summer2021] Translate the registry_spi.md
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #402:
URL: https://github.com/apache/dolphinscheduler-website/pull/402#discussion_r666174153
##########
File path: docs/en-us/dev/user_doc/registry_spi.md
##########
@@ -0,0 +1,27 @@
+### DolphinScheduler Registry SPI main design
+
+#### How to use it？
+
+First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` to install the plugin for generating the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry.
+
+Next, do the following configuration (using zookeeper as an example)
+
+| Parameter | Default | Description |
+| :---------------------: | ------------------------------------------------------------ | ---------------------------------------- |
+| zookeeper.quorum | localhost:2181 | zk Cluster connection information |
Review comment:
delete this. it's error config param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] ptyp commented on a change in pull request #402: [Summer2021] Translate the registry_spi.md
Posted by GitBox <gi...@apache.org>.
ptyp commented on a change in pull request #402:
URL: https://github.com/apache/dolphinscheduler-website/pull/402#discussion_r668199852
##########
File path: docs/zh-cn/dev/user_doc/registry_spi.md
##########
@@ -20,7 +19,7 @@ registry.servers|127.0.0.1:2181|zk 连接地址
#### FAQ
1: not found registry plugin
Review comment:
If you change the English version, please remember to modify the Chinese version.
##########
File path: docs/en-us/dev/user_doc/registry_spi.md
##########
@@ -0,0 +1,26 @@
+### DolphinScheduler Registry SPI main design
+
+#### How to use it？
+
+First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` to install the plugin for generating the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry.
+
+Next, do the following configuration (using zookeeper as an example)
+
+| Parameter | Default | Description |
+| :---------------------: | ------------------------------------------------------------ | ---------------------------------------- |
+| registry.plugin.dir | /Users/username/workspaces/dolphinscheduler/dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry | Registration Center Plugin Directory |
+| registry.plugin.name\| | zookeeper | Registration Center specific plugin name |
Review comment:
\ is redundant here.
Another thing is that only the first letters of the words in the first row of the Description column are capitalized. You should keep the consistency like changing the first letters of the remaining rows to upper case or changing the first letters of the first row to lower case.
##########
File path: docs/en-us/dev/user_doc/registry_spi.md
##########
@@ -0,0 +1,26 @@
+### DolphinScheduler Registry SPI main design
+
+#### How to use it？
+
+First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` to install the plugin for generating the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry.
+
+Next, do the following configuration (using zookeeper as an example)
+
+| Parameter | Default | Description |
+| :---------------------: | ------------------------------------------------------------ | ---------------------------------------- |
+| registry.plugin.dir | /Users/username/workspaces/dolphinscheduler/dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry | Registration Center Plugin Directory |
+| registry.plugin.name\| | zookeeper | Registration Center specific plugin name |
+| registry.plugin.binding | registry | Dolphinscheduler plugin category |
+| registry.servers | 127.0.0.1:2181 | ZK connection address |
+
+For the specific configuration information, please refer to the parameter information that provided by the specific plugin. Taking zk as an example, all the parameters of this configuration information about zk are in the class org/apache/dolphinscheduler/plugin/registry/zookeeper/ZookeeperConfiguration.java. If a parameter is needed to be changed to a specific value instead of the default, it can be configured directly in the registry. However, the prefix should be added to indicate this is a parameter of the registry. For example, "base.sleep.time.ms" should be configured in the registry as: "registry.base.sleep.time.ms=100".
+
+#### FAQ
+
+1: not found registry plugin
Review comment:
"registry plugin not found" would be more delicate.
##########
File path: docs/en-us/dev/user_doc/registry_spi.md
##########
@@ -0,0 +1,26 @@
+### DolphinScheduler Registry SPI main design
+
+#### How to use it？
+
+First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` to install the plugin for generating the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry.
+
+Next, do the following configuration (using zookeeper as an example)
Review comment:
"Next, please follow the configuration below (using zookeeper as an example)." should be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] QuakeWang commented on a change in pull request #402: [Summer2021] Translate the registry_spi.md
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on a change in pull request #402:
URL: https://github.com/apache/dolphinscheduler-website/pull/402#discussion_r666261896
##########
File path: docs/en-us/dev/user_doc/registry_spi.md
##########
@@ -0,0 +1,27 @@
+### DolphinScheduler Registry SPI main design
+
+#### How to use it？
+
+First you need to execute the `mvn -U install package -Prelease -Dmaven.test.skip=true` to install the plugin for generating the plugin JAR of the registry. The directory is: dolphinscheduler-dist/target/dolphinscheduler-dist-1.3.6-SNAPSHOT/lib/plugin/registry.
+
+Next, do the following configuration (using zookeeper as an example)
+
+| Parameter | Default | Description |
+| :---------------------: | ------------------------------------------------------------ | ---------------------------------------- |
+| zookeeper.quorum | localhost:2181 | zk Cluster connection information |
Review comment:
I have deleted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] dailidong merged pull request #402: [Summer2021] Translate the registry_spi.md
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #402:
URL: https://github.com/apache/dolphinscheduler-website/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org