You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/05 11:05:14 UTC
[GitHub] [kylin] hit-lacus opened a new pull request #1040: KYLIN-4206
Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
hit-lacus opened a new pull request #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1040: KYLIN-4206
Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924110
## Pull Request Test Coverage Report for [Build 5487](https://coveralls.io/builds/27922995)
* **0** of **11** **(0.0%)** changed or added relevant lines in **4** files are covered.
* **6** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.457%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/27922995/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1105) | 0 | 1 | 0.0%
| [metrics-reporter-hive/src/main/java/org/apache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://coveralls.io/builds/27922995/source?filename=metrics-reporter-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2Fhive%2FHiveProducer.java#L96) | 0 | 1 | 0.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/CLIHiveClient.java](https://coveralls.io/builds/27922995/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCLIHiveClient.java#L44) | 0 | 2 | 0.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/HiveMetaStoreClientFactory.java](https://coveralls.io/builds/27922995/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveMetaStoreClientFactory.java#L30) | 0 | 7 | 0.0%
<!-- | **Total:** | **0** | **11** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/27922995/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/27922995/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **6** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/27922995/badge)](https://coveralls.io/builds/27922995) |
| :-- | --: |
| Change from base [Build 5484](https://coveralls.io/builds/27920241): | -0.003% |
| Covered Lines: | 24071 |
| Relevant Lines: | 87669 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1040: KYLIN-4206 Support
Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924771
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=h1) Report
> Merging [#1040](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c58c9bf14200cddc6a2e46375dcc81ca98e45725?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1040/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1040 +/- ##
============================================
- Coverage 25.01% 24.99% -0.02%
+ Complexity 6180 6179 -1
============================================
Files 1437 1438 +1
Lines 87639 87669 +30
Branches 12250 12257 +7
============================================
- Hits 21919 21914 -5
- Misses 63568 63601 +33
- Partials 2152 2154 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kylin/source/hive/HiveMetaStoreClientFactory.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVNZXRhU3RvcmVDbGllbnRGYWN0b3J5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.34% <0%> (-0.02%)` | `44 <0> (ø)` | |
| [...va/org/apache/kylin/source/hive/CLIHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NMSUhpdmVDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-bWV0cmljcy1yZXBvcnRlci1oaXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL2hpdmUvSGl2ZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...che/kylin/stream/core/storage/CheckPointStore.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvQ2hlY2tQb2ludFN0b3JlLmphdmE=) | `63.63% <0%> (-3.04%)` | `21% <0%> (-1%)` | |
| [...n/java/org/apache/kylin/job/dao/ExecutableDao.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9kYW8vRXhlY3V0YWJsZURhby5qYXZh) | `27.51% <0%> (-1.8%)` | `24% <0%> (ø)` | |
| [...c/main/java/org/apache/kylin/cube/CubeSegment.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVTZWdtZW50LmphdmE=) | `49.34% <0%> (-1.11%)` | `64% <0%> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [.../org/apache/kylin/query/util/PushDownExecutor.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25FeGVjdXRvci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=footer). Last update [c58c9bf...2214960](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1040: KYLIN-4206 Support Glue
as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924110
## Pull Request Test Coverage Report for [Build 5487](https://coveralls.io/builds/27922995)
* **0** of **11** **(0.0%)** changed or added relevant lines in **4** files are covered.
* **6** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.457%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/27922995/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1105) | 0 | 1 | 0.0%
| [metrics-reporter-hive/src/main/java/org/apache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://coveralls.io/builds/27922995/source?filename=metrics-reporter-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2Fhive%2FHiveProducer.java#L96) | 0 | 1 | 0.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/CLIHiveClient.java](https://coveralls.io/builds/27922995/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCLIHiveClient.java#L44) | 0 | 2 | 0.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/HiveMetaStoreClientFactory.java](https://coveralls.io/builds/27922995/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveMetaStoreClientFactory.java#L30) | 0 | 7 | 0.0%
<!-- | **Total:** | **0** | **11** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/27922995/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/27922995/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **6** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/27922995/badge)](https://coveralls.io/builds/27922995) |
| :-- | --: |
| Change from base [Build 5484](https://coveralls.io/builds/27920241): | -0.003% |
| Covered Lines: | 24071 |
| Relevant Lines: | 87669 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] hit-lacus merged pull request #1040: KYLIN-4206 Support
Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls edited a comment on issue #1040: KYLIN-4206
Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924110
## Pull Request Test Coverage Report for [Build 5486](https://coveralls.io/builds/27921558)
* **0** of **11** **(0.0%)** changed or added relevant lines in **4** files are covered.
* **190** unchanged lines in **9** files lost coverage.
* Overall coverage increased (+9.0e**-05%**) to **27.459%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/27921558/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1105) | 0 | 1 | 0.0%
| [metrics-reporter-hive/src/main/java/org/apache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://coveralls.io/builds/27921558/source?filename=metrics-reporter-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2Fhive%2FHiveProducer.java#L96) | 0 | 1 | 0.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/CLIHiveClient.java](https://coveralls.io/builds/27921558/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCLIHiveClient.java#L44) | 0 | 2 | 0.0%
| [source-hive/src/main/java/org/apache/kylin/source/hive/HiveMetaStoreClientFactory.java](https://coveralls.io/builds/27921558/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveMetaStoreClientFactory.java#L30) | 0 | 7 | 0.0%
<!-- | **Total:** | **0** | **11** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/27921558/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/27921558/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/ColumnarSplitDictReader.java](https://coveralls.io/builds/27921558/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FColumnarSplitDictReader.java#L42) | 12 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/ColumnarSplitDataReader.java](https://coveralls.io/builds/27921558/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FColumnarSplitDataReader.java#L39) | 14 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/ColumnToRowJob.java](https://coveralls.io/builds/27921558/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FColumnToRowJob.java#L46) | 16 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/ExtractDictionaryFromGlobalMapper.java](https://coveralls.io/builds/27921558/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FExtractDictionaryFromGlobalMapper.java#L55) | 19 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/ColumnarSplitInputFormat.java](https://coveralls.io/builds/27921558/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FColumnarSplitInputFormat.java#L42) | 19 | 0.0% |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/streaming/SaveDictStep.java](https://coveralls.io/builds/27921558/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fstreaming%2FSaveDictStep.java#L91) | 32 | 0.0% |
| [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/27921558/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L94) | 72 | 0.0% |
<!-- | **Total:** | **190** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/27921558/badge)](https://coveralls.io/builds/27921558) |
| :-- | --: |
| Change from base [Build 5484](https://coveralls.io/builds/27920241): | 9.0e-05% |
| Covered Lines: | 24073 |
| Relevant Lines: | 87668 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1040: KYLIN-4206
Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924771
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=h1) Report
> Merging [#1040](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c4a3b4948c589b06cb6a483535eebaed0377c7de?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1040/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1040 +/- ##
============================================
- Coverage 24.99% 24.99% -0.01%
Complexity 6179 6179
============================================
Files 1437 1438 +1
Lines 87661 87669 +8
Branches 12255 12257 +2
============================================
- Hits 21915 21914 -1
- Misses 63593 63601 +8
- Partials 2153 2154 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kylin/source/hive/HiveMetaStoreClientFactory.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVNZXRhU3RvcmVDbGllbnRGYWN0b3J5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.34% <0%> (-0.02%)` | `44 <0> (ø)` | |
| [...va/org/apache/kylin/source/hive/CLIHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NMSUhpdmVDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-bWV0cmljcy1yZXBvcnRlci1oaXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL2hpdmUvSGl2ZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (+2.27%)` | `8% <0%> (+1%)` | :arrow_up: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=footer). Last update [c4a3b49...2214960](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1040: KYLIN-4206
Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924771
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=h1) Report
> Merging [#1040](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c4a3b4948c589b06cb6a483535eebaed0377c7de?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1040/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1040 +/- ##
============================================
- Coverage 24.99% 24.99% -0.01%
Complexity 6179 6179
============================================
Files 1437 1438 +1
Lines 87661 87669 +8
Branches 12255 12257 +2
============================================
- Hits 21915 21914 -1
- Misses 63593 63601 +8
- Partials 2153 2154 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kylin/source/hive/HiveMetaStoreClientFactory.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVNZXRhU3RvcmVDbGllbnRGYWN0b3J5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.34% <0%> (-0.02%)` | `44 <0> (ø)` | |
| [...va/org/apache/kylin/source/hive/CLIHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NMSUhpdmVDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-bWV0cmljcy1yZXBvcnRlci1oaXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL2hpdmUvSGl2ZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (+2.27%)` | `8% <0%> (+1%)` | :arrow_up: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=footer). Last update [c4a3b49...2214960](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] hit-lacus commented on issue #1040: KYLIN-4206 Support Glue
as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570975166
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1040: KYLIN-4206
Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1040: KYLIN-4206 Support Glue as Hive Metatdata; KYLIN-4298 Fix Wrong FS
URL: https://github.com/apache/kylin/pull/1040#issuecomment-570924771
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=h1) Report
> Merging [#1040](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/c4a3b4948c589b06cb6a483535eebaed0377c7de?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1040/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1040 +/- ##
============================================
- Coverage 24.99% 24.99% -0.01%
Complexity 6179 6179
============================================
Files 1437 1438 +1
Lines 87661 87669 +8
Branches 12255 12257 +2
============================================
- Hits 21915 21914 -1
- Misses 63593 63601 +8
- Partials 2153 2154 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../kylin/source/hive/HiveMetaStoreClientFactory.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVNZXRhU3RvcmVDbGllbnRGYWN0b3J5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.34% <0%> (-0.02%)` | `44 <0> (ø)` | |
| [...va/org/apache/kylin/source/hive/CLIHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NMSUhpdmVDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/kylin/metrics/lib/impl/hive/HiveProducer.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-bWV0cmljcy1yZXBvcnRlci1oaXZlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9tZXRyaWNzL2xpYi9pbXBsL2hpdmUvSGl2ZVByb2R1Y2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (+2.27%)` | `8% <0%> (+1%)` | :arrow_up: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1040/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=footer). Last update [c4a3b49...2214960](https://codecov.io/gh/apache/kylin/pull/1040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services