[GitHub] [camel] davsclaus commented on a diff in pull request #9592: Rethrow exceptions in Azure Service Bus consumer

["davsclaus (via GitHub)" <gi...@apache.org>]

davsclaus commented on code in PR #9592:
URL: https://github.com/apache/camel/pull/9592#discussion_r1143850682


##########
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##########
@@ -145,6 +145,9 @@ private void onEventListener(final ServiceBusReceivedMessage message) {
         // use default consumer callback
         AsyncCallback cb = defaultConsumerCallback(exchange, true);
         getAsyncProcessor().process(exchange, cb);
+        if (exchange.getException() != null) {

Review Comment:
   Its actually a bit more complex if you use aync processing, as the "result" is only done when the callback is done, and not when the process is returned.
   
   Is there some API in azure to rollback/abandon we can explicit call instead of rethrowing exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org