You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/26 20:41:08 UTC
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1665: Parquet: Introduce a limit to evaluate IN predicates
RussellSpitzer commented on a change in pull request #1665:
URL: https://github.com/apache/iceberg/pull/1665#discussion_r512254330
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java
##########
@@ -140,6 +142,9 @@
builder.withNameMapping(NameMappingParser.fromJson(nameMapping));
}
+ // TODO: propagate properties for Avro
+ // properties.forEach(builder::set);
Review comment:
Maybe we should have an Precondition til this is implemented throwing an exception if a property is passed
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java
##########
@@ -140,6 +142,9 @@
builder.withNameMapping(NameMappingParser.fromJson(nameMapping));
}
+ // TODO: propagate properties for Avro
+ // properties.forEach(builder::set);
Review comment:
Maybe we should have an Precondition until this is implemented throwing an exception if a property is passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org