Re: svn commit: r35990 - branches/1.6.x

[Greg Stein <gs...@gmail.com>]

This was an incorrect change.

I voted for those changes to be in 1.6.1. I *specifically* did not
vote for them to be allowed into 1.6.0.

That said, I *was* about to change my vote to allow the text fixes and
the fsfs fix in. hwright has already assumed that and rolled the fixes
into the branch.

But I was NOT going to vote the last-minute sqlite build change into
1.6.0. Thus, hwright has now had to back that change out of the
branch.

I'm going to go fix up STATUS now.

-g

On Thu, Feb 19, 2009 at 16:55, Bert Huijben <rh...@sharpsvn.net> wrote:
> Author: rhuijben
> Date: Thu Feb 19 07:55:08 2009
> New Revision: 35990
>
> Log:
> * STATUS: Following up on rolling rc2, make all nominees targeted for 1.6.0.
>
> Modified:
>   branches/1.6.x/STATUS
>
> Modified: branches/1.6.x/STATUS
> URL: http://svn.collab.net/viewvc/svn/branches/1.6.x/STATUS?pathrev=35990&r1=35989&r2=35990
> ==============================================================================
> --- branches/1.6.x/STATUS       Thu Feb 19 07:51:14 2009        (r35989)
> +++ branches/1.6.x/STATUS       Thu Feb 19 07:55:08 2009        (r35990)
> @@ -14,37 +14,7 @@ Status of 1.6.0:
>  ================
>
>  Candidate changes:
> -
> - * r35930
> -   Adjust basic_tests.py 12 for compatability with Windows and Python 2.5+.
> -   Justification:
> -     Stops spurious test failures.
> -    Votes:
> -     +1: pburba, rhuijben
> -     +1: gstein (for 1.6.1)
> -
> - * r35943
> -   Avoid some tree_conflict_tests.py cleanup errors on Windows with BDB
> -   when building multiple sandboxes in the same test.
> -   Justification:
> -     Stops spurious test failures.
> -    Votes:
> -     +1: pburba, rhuijben
> -     +1: gstein (for 1.6.1)
> -
> - * r35950
> -   Make fsfs implementation of svn_fs_commit_txn adhere to API promises.
> -    Votes:
> -     +1: pburba, rhuijben
> -     +1: gstein (for 1.6.1)
> -
> - * r35967
> -   Add support to build and use SQLite amalgamation version on Windows.
> -   This change implements the same behavior as *nix build system does.
> -   Votes:
> -     +1: rhuijben, pburba (not strictly for 1.6.0)
> -     +1: gstein (for 1.6.1)
> -
> +
>  * r35968,r35974
>    Buffer overflow on ensuring a 0 byte string buffer
>    Justification:
> @@ -54,11 +24,6 @@ Candidate changes:
>    Votes:
>      +1: rhuijben, gstein
>
> -Status of 1.6.1:
> -================
> -
> -Candidate changes:
> -
>  * r35977
>    Remove the implicit recanonicalize in svn_path_url_add_component2 that
>    should have been part of r35732 that started asserting its behavior.
> @@ -78,7 +43,31 @@ Candidate changes:
>    Votes:
>      +1: rhuijben
>
> -Approved changes (all releases):
> -================================
> +Approved changes:
> +=================
>
> -  No approved changes at the moment!
> + * r35930
> +   Adjust basic_tests.py 12 for compatability with Windows and Python 2.5+.
> +   Justification:
> +     Stops spurious test failures.
> +    Votes:
> +     +1: pburba, rhuijben, gstein
> +
> + * r35943
> +   Avoid some tree_conflict_tests.py cleanup errors on Windows with BDB
> +   when building multiple sandboxes in the same test.
> +   Justification:
> +     Stops spurious test failures.
> +    Votes:
> +     +1: pburba, rhuijben, gstein
> +
> +* r35950
> +   Make fsfs implementation of svn_fs_commit_txn adhere to API promises.
> +    Votes:
> +     +1: pburba, rhuijben, gstein
> +
> + * r35967
> +   Add support to build and use SQLite amalgamation version on Windows.
> +   This change implements the same behavior as *nix build system does.
> +   Votes:
> +     +1: rhuijben, pburba, gstein
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=1192505
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1192619