You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/04 09:29:08 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #4055: db.properties: Enforce UTC timezone by default
rhtyd opened a new pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055
This would give users ability to change the timezone
The general assumption is that CloudStack infra/services would run on UTC with ntp/synchronised time. Looks like some users prefer local time in DB.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623389946
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623380728
Hi @Doni7722 I've added the usage url params as well, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Doni7722 commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
Doni7722 commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623381999
Hi @rhtyd there is a small typo. you changed the url params to:
db.usage.url.params=serverTimezone=UTC
but I think it should be:
db.usage.url.params=&serverTimezone=UTC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623757655
<b>Trillian test result (tid-1502)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4055-t1502-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 3609.11 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 34.43 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623390440
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624479963
however both jenkins and travis failed misserably.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Doni7722 commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
Doni7722 commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623379571
Hi Rohit
I could check the fix in my lab environment (CloudStack 4.14 RC1, CentOS 7 OS) and can confirm that it fixed the issue, where cloudstack-management service is not able to start as timezone informations are missing.
If users have the usage service too they will need to implement the parameters for the usage DB as well. Otherwise they won't be able to start the cloudstack-usage service.
"db.usage.url.params=" in the /etc/cloudstack/management/db.properties file would be the one for the usage service
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624292712
Documentation PR in progress - also please review whoever and LGTM if you are happy with it:
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr112/upgrading/upgrade/upgrade-4.13.html#time-zone-requirements (this is test version/build)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb edited a comment on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
andrijapanicsb edited a comment on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624292712
Documentation PR in progress - also please review whoever and LGTM if you are happy with it:
https://github.com/apache/cloudstack-documentation/pull/112
Preview build at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr112/upgrading/upgrade/upgrade-4.13.html#time-zone-requirements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624480106
let's try again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623388934
Thanks for confirming @Doni7722 :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624480214
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624019243
@shwstppr again k8 failures, can you assess these, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624473898
one remark about the use of articles in the english language in the doc change, @andrijapanicsb :p . I'm fine with merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623384478
@Doni7722 the db.cloud.url.params= don't begin with an `&` - have you tested the value without a `&` in your env, assuming if it doesn't work I'm happy to change per your comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624290713
Alright....
tested this thoroughly enough, I believe:
## ACS 4.13, clean install (no db.properties customisation), usage job runs in CEST!
- UTC timezone on mgmt server = all times in DB (cloud and cloud_usage!) are in UTC, but i.e. events in GUI displayed with my local time (of my laptop, which is CEST - from my perspective that is how it should be)
- Changed mgmt server time to CEST, rebooted server (for fun) = no changes in DB/GUI
## Upgraded to 4.14 with adding "serverTimezone=UTC" so that mgmt starts fine
- all times still in UTC in DBs (no change to before) = good/consistency
- changed db.properties to serverTimezone=Europe/Belgrade on both lines (this is CEST actually)
- no changes in DB at all...I'm talking both about events in "cloud" and the usage records (both raw and digested in cloud_usage table) - all stay in UTC times - i.e. DB is not affected by this change - which is funny - but I'm OK with this
- GUI is now showing times from UTC (i.e. my time minus 2h) - which is wrong - i.e. we are not really honouring the timezone in DB records, but it IS reflected in GUI - this is not optimal - but is also NOT critical whatsoever...
/cc @rhtyd @DaanHoogland @Doni7722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Doni7722 commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
Doni7722 commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624481102
I can confirm and had same results as @andrijapanicsb had. Usage DB entries and Cloud DB entries all in UTC but CMK gives me CEST restults back. However the GUI gives me still UTC (inside the Events) but that's may caused by my environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623400710
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624521835
Jenkins and Travis blues brothers look happy now, 2 x LGTMs, manual and regression testing OK (k8s tests are not related).
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624040391
@DaanHoogland looked into the logs, k8s cluster failed to reach the desired state in the given time. I'll try to add further improvements to test and cks backend. Failure not related to this PR changes as other tests from the same smoke test ran fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623400256
Packaging result: ✔centos7 ✔debian. JID-1210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb edited a comment on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
andrijapanicsb edited a comment on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-624290713
Alright....
tested this thoroughly enough, I believe:
## ACS 4.13, clean install (no db.properties customisation), usage job runs in CEST!
- UTC timezone on mgmt server = all times in DB (cloud and cloud_usage!) are in UTC, but i.e. events in GUI displayed with my local time (of my laptop, which is CEST - from my perspective that is how it should be)
- Changed mgmt server time to CEST, rebooted server (for fun) = no changes in DB/GUI
## Upgraded to 4.14 with adding "serverTimezone=UTC" so that mgmt starts fine
- SAME AS BEFORE - i.e. all times still in UTC in DBs and CEST in GUI (my local time) = good/consistency
- changed db.properties to serverTimezone=Europe/Belgrade on both lines (this is CEST actually)
- no changes in DB at all...I'm talking both about events in "cloud" and the usage records (both raw and digested in cloud_usage table) - all stay in UTC times - i.e. DB is not affected by this change - which is funny - but I'm OK with this
- GUI is now showing times from UTC (i.e. my time minus 2h) - which is wrong - i.e. we are not really honouring the timezone in DB records, but it IS reflected in GUI - this is not optimal - but is also NOT critical whatsoever...
/cc @rhtyd @DaanHoogland @Doni7722
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623392076
@Doni7722 Can you also confirm, if post thing change in your test env if the usage records have the correct time according to configured timezone (in global settings) if you're using a non-UTC timezone in the usage related global settings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Doni7722 commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
Doni7722 commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623386679
@rhtyd yes works with & and without (tested both now) so I think it's better without & as you wrote the begining should be without.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623401209
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4055: db.properties: Enforce UTC timezone by default
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4055:
URL: https://github.com/apache/cloudstack/pull/4055#issuecomment-623384478
@Doni7722 the db.cloud.url.params= don't begin with an `&` - have you tested the value without a `&` in your env, if it doesn't work for you I'm happy to change per your comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org