You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by so...@apache.org on 2017/03/14 08:15:07 UTC

[4/7] incubator-weex git commit: * [android] protect NPE for support-v7

* [android] protect NPE for support-v7


Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/23d8e9df
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/23d8e9df
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/23d8e9df

Branch: refs/heads/0.11-dev
Commit: 23d8e9df996d0d96e0f920bb3e0056f40b6c9569
Parents: f759a8c
Author: zshshr <zh...@gmail.com>
Authored: Tue Mar 14 14:22:07 2017 +0800
Committer: zshshr <zh...@gmail.com>
Committed: Tue Mar 14 14:22:07 2017 +0800

----------------------------------------------------------------------
 .../adapter/WXRecyclerViewOnScrollListener.java | 24 ++++++++++++--------
 1 file changed, 15 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/23d8e9df/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/WXRecyclerViewOnScrollListener.java
----------------------------------------------------------------------
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/WXRecyclerViewOnScrollListener.java b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/WXRecyclerViewOnScrollListener.java
index 4a0d69a..597c1cb 100755
--- a/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/WXRecyclerViewOnScrollListener.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/WXRecyclerViewOnScrollListener.java
@@ -312,15 +312,21 @@ public class WXRecyclerViewOnScrollListener extends RecyclerView.OnScrollListene
         if (mFirstPositions == null || newSpanCount != mFirstPositions.length) {
           mFirstPositions = new int[newSpanCount];
         }
-        staggeredGridLayoutManager.findFirstVisibleItemPositions(mFirstPositions);
-        mFirstVisibleItemPosition = findMin(mFirstPositions);
-        staggeredGridLayoutManager.findLastVisibleItemPositions(mLastPositions);
-        mLastVisibleItemPosition = findMax(mLastPositions);
-        iOnLoadMoreListener.notifyAppearStateChange(
-            mFirstVisibleItemPosition
-            , mLastVisibleItemPosition
-            , dx
-            , dy);
+        try{
+          staggeredGridLayoutManager.findFirstVisibleItemPositions(mFirstPositions);
+          mFirstVisibleItemPosition = findMin(mFirstPositions);
+          staggeredGridLayoutManager.findLastVisibleItemPositions(mLastPositions);
+          mLastVisibleItemPosition = findMax(mLastPositions);
+          iOnLoadMoreListener.notifyAppearStateChange(
+              mFirstVisibleItemPosition
+              , mLastVisibleItemPosition
+              , dx
+              , dy);
+
+        }catch(Exception e){
+          e.printStackTrace();
+        }
+
       } else {
         throw new RuntimeException(
             "Unsupported LayoutManager used. Valid ones are LinearLayoutManager, GridLayoutManager and StaggeredGridLayoutManager");