You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "umeshme (via GitHub)" <gi...@apache.org> on 2024/11/11 11:28:13 UTC
[I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
umeshme opened a new issue, #30893:
URL: https://github.com/apache/superset/issues/30893
### Bug description
The bug is that
1. Embedd the Superset dashboard.
2. Click on Edit dashboard button
3. Click on discard button,
Expected: It should redirect me to the embedded dashboard
Actual: It shows screen which keeps on loading
Logs does not show any error.
In network trace after this GET call, nothing happens
embedded/412a5023-617f-435b-9e08-2e821b581902
In case if anyone came across similar issues, please advice.
### Screenshots/recordings
_No response_
### Superset version
master / latest-dev
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30893:
URL: https://github.com/apache/superset/issues/30893#issuecomment-3156057500
Agreed... the functionality is not intended to work. We're open to PRs that somehow properly detect embedded mode and disable the appropriate button(s), of course. A means to determine embedded state might help us disable a _bunch_ of things that shouldn't be happening/supported in embedded dashboards, actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #30893:
URL: https://github.com/apache/superset/issues/30893#issuecomment-2467949371
<!-- Greeting -->
Hey @umeshme! 👋 I'm here to help you with any bugs, questions, or contributions you have for Superset. I'll assist you while we wait for a human maintainer to join the conversation.
<!-- Answer -->
The issue you're experiencing with the discard button in the embedded dashboard not functioning as expected could be related to the implementation of the discard functionality or the state management during the transition from edit mode back to view mode. The expected behavior of the discard button is to undo changes and return to the embedded dashboard view <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/cypress-base/cypress/e2e/dashboard/editmode.test.ts)</sup>.
Here are a few things you might want to check or try:
1. **State Management**: Ensure that the state transition from edit mode to view mode is correctly handled. The `SET_EDIT_MODE` action should be dispatched with `editMode: false` to switch back to view mode <sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/src/dashboard/actions/dashboardState.js)</sup>.
2. **Network Requests**: Since you mentioned that the network trace shows a GET call with no further activity, it might be worth investigating if there are any missing or failed network requests that should be triggered when the discard button is clicked.
3. **JavaScript Console**: Check the browser's JavaScript console for any errors or warnings that might provide more insight into what's going wrong.
4. **Code Review**: Review the implementation of the `discardChanges` function and ensure it is correctly defined and invoked. The function should handle the necessary state updates and UI transitions.
If these steps don't resolve the issue, it might be helpful to look into recent changes or commits related to the embedded dashboard or discard functionality for any potential bugs or regressions.
<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #30893:
URL: https://github.com/apache/superset/issues/30893#issuecomment-2839274994
@Vitor-Avila might know better than me, but I didn't think we actually supported edit mode in embedded dashboards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
Posted by "jamiemac87 (via GitHub)" <gi...@apache.org>.
jamiemac87 commented on issue #30893:
URL: https://github.com/apache/superset/issues/30893#issuecomment-2541038747
Similar issue with version `4.1.1`.
**Repro Steps:**
1. Make guest role Admin
2. embed dashboard
3. Click on "edit dashboard" within title
4. click "discard" button
Results in following error
```
{"errors": [{"message": "403 Forbidden: You don't have the permission to access the requested resource. It is either read-protected or not readable by the server.", "error_type": "GENERIC_BACKEND_ERROR", "level": "error", "extra": {"issue_codes": [{"code": 1011, "message": "Issue 1011 - Superset encountered an unexpected error."}]}}]}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on issue #30893:
URL: https://github.com/apache/superset/issues/30893#issuecomment-2839315569
@rusackas technically what's visible/"possible" in embedded mode depends on the permissions assigned to the role set for the guest role. In reality, I think embedded was mostly built for view mode, so I don't think this is expected to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #30893: Embedded dashboard- discard button does not work after click on Edit dashboard in embedded dashboard
URL: https://github.com/apache/superset/issues/30893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org