You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Vinod Panicker (JIRA)" <ji...@apache.org> on 2005/05/20 09:15:00 UTC

[jira] Created: (DIRMINA-44) SSLFilter doesn't override exceptionCaught

SSLFilter doesn't override exceptionCaught
------------------------------------------

         Key: DIRMINA-44
         URL: http://issues.apache.org/jira/browse/DIRMINA-44
     Project: Directory MINA
        Type: Bug
    Versions: 0.7, 0.9, 0.7.1    
    Reporter: Vinod Panicker
 Assigned to: Trustin Lee 
 Attachments: sslfilter-0.7.1.patch

The SSLFilter currently doesnt override exceptionCaught, and rather just forwards all the exceptions to the nextFilter.

This causes problems if there is an SSLException thrown by the SSLEngine during the SSL Handshake/Communication.

Providing a patch that fixes this against the 0.7.1 branch.

Patch for 0.9 coming soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-44) SSLFilter doesn't override exceptionCaught

Posted by "Vinod Panicker (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-44?page=all ]

Vinod Panicker updated DIRMINA-44:
----------------------------------

    Attachment: sslfilter-0.7.1.patch

* Adds exceptionCaught method that forwards exceptions to nextFilter.
* Handles necessary Exceptions that were being ignored.

> SSLFilter doesn't override exceptionCaught
> ------------------------------------------
>
>          Key: DIRMINA-44
>          URL: http://issues.apache.org/jira/browse/DIRMINA-44
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7, 0.9, 0.7.1
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>  Attachments: sslfilter-0.7.1.patch
>
> The SSLFilter currently doesnt override exceptionCaught, and rather just forwards all the exceptions to the nextFilter.
> This causes problems if there is an SSLException thrown by the SSLEngine during the SSL Handshake/Communication.
> Providing a patch that fixes this against the 0.7.1 branch.
> Patch for 0.9 coming soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DIRMINA-44) SSLFilter doesn't override exceptionCaught

Posted by "Vinod Panicker (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-44?page=all ]
     
Vinod Panicker closed DIRMINA-44:
---------------------------------


> SSLFilter doesn't override exceptionCaught
> ------------------------------------------
>
>          Key: DIRMINA-44
>          URL: http://issues.apache.org/jira/browse/DIRMINA-44
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7, 0.7.1
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>      Fix For: 0.7.2
>  Attachments: sslfilter-0.7.1.patch, sslfilter-0.9.patch
>
> The SSLFilter currently doesnt override exceptionCaught, and rather just forwards all the exceptions to the nextFilter.
> This causes problems if there is an SSLException thrown by the SSLEngine during the SSL Handshake/Communication.
> Providing a patch that fixes this against the 0.7.1 branch.
> Patch for 0.9 coming soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (DIRMINA-44) SSLFilter doesn't override exceptionCaught

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-44?page=all ]
     
Trustin Lee resolved DIRMINA-44:
--------------------------------

     Resolution: Fixed
    Fix Version: 0.7.2

This issue is considered resolved.  Please let me know if you don't received any execptionCaught event.  It might be a bug of FilterChains.

> SSLFilter doesn't override exceptionCaught
> ------------------------------------------
>
>          Key: DIRMINA-44
>          URL: http://issues.apache.org/jira/browse/DIRMINA-44
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7, 0.7.1
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>      Fix For: 0.7.2
>  Attachments: sslfilter-0.7.1.patch, sslfilter-0.9.patch
>
> The SSLFilter currently doesnt override exceptionCaught, and rather just forwards all the exceptions to the nextFilter.
> This causes problems if there is an SSLException thrown by the SSLEngine during the SSL Handshake/Communication.
> Providing a patch that fixes this against the 0.7.1 branch.
> Patch for 0.9 coming soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-44) SSLFilter doesn't override exceptionCaught

Posted by "Vinod Panicker (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-44?page=all ]

Vinod Panicker updated DIRMINA-44:
----------------------------------

    Attachment: sslfilter-0.9.patch

* Added exceptionCaught() method

> SSLFilter doesn't override exceptionCaught
> ------------------------------------------
>
>          Key: DIRMINA-44
>          URL: http://issues.apache.org/jira/browse/DIRMINA-44
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7, 0.7.1, 0.9
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>  Attachments: sslfilter-0.7.1.patch, sslfilter-0.9.patch
>
> The SSLFilter currently doesnt override exceptionCaught, and rather just forwards all the exceptions to the nextFilter.
> This causes problems if there is an SSLException thrown by the SSLEngine during the SSL Handshake/Communication.
> Providing a patch that fixes this against the 0.7.1 branch.
> Patch for 0.9 coming soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-44) SSLFilter doesn't override exceptionCaught

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-44?page=all ]

Trustin Lee updated DIRMINA-44:
-------------------------------

    Version:     (was: 0.9)

SSLFilter extends IoFilterAdapter that already implements exceptionCaught correctly, so it should be no problem for both 0.7 and 0.9 stream.

But for 0.7, I caught SSLException and called nextFilter.exceptionCaught instead of just throwing it out so that FilterChain can handle exceptions behind the scene.  I fixed this issue.  Please look at this diff:

http://svn.apache.org/viewcvs.cgi/directory/network/branches/0.7/src/java/org/apache/mina/io/filter/SSLFilter.java?rev=171079&r1=170526&r2=171079&diff_format=h

> SSLFilter doesn't override exceptionCaught
> ------------------------------------------
>
>          Key: DIRMINA-44
>          URL: http://issues.apache.org/jira/browse/DIRMINA-44
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7, 0.7.1
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>      Fix For: 0.7.2
>  Attachments: sslfilter-0.7.1.patch, sslfilter-0.9.patch
>
> The SSLFilter currently doesnt override exceptionCaught, and rather just forwards all the exceptions to the nextFilter.
> This causes problems if there is an SSLException thrown by the SSLEngine during the SSL Handshake/Communication.
> Providing a patch that fixes this against the 0.7.1 branch.
> Patch for 0.9 coming soon.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira