[GitHub] [kafka] ableegoldman commented on a change in pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #8312:
URL: https://github.com/apache/kafka/pull/8312#discussion_r439693064



##########
File path: clients/src/main/java/org/apache/kafka/common/requests/DescribeConfigsResponse.java
##########
@@ -293,158 +208,66 @@ public ConfigSource source() {
         }
     }
 
+    public Map<ConfigResource, DescribeConfigsResponseData.DescribeConfigsResult> resultMap() {
+        return data().results().stream().collect(Collectors.toMap(
+            configsResult ->
+                    new ConfigResource(ConfigResource.Type.forId(configsResult.resourceType()),
+                            configsResult.resourceName()),
+            Function.identity()));
+    }
 
-    private final int throttleTimeMs;
-    private final Map<ConfigResource, Config> configs;
+    private final DescribeConfigsResponseData data;
 
-    public DescribeConfigsResponse(int throttleTimeMs, Map<ConfigResource, Config> configs) {
-        this.throttleTimeMs = throttleTimeMs;
-        this.configs = Objects.requireNonNull(configs, "configs");

Review comment:
       Hey @mimaison @tombentley, removing this constructor seems to have broken the build (it was used in `TopicAdminTest`). Can we get a hotfix for this to unblock other PRs?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org