[GitHub] [flink-statefun] igalshilman commented on a change in pull request #129: [FLINK-18812][core] Upgrade Flink to 1.11.1

[GitBox <gi...@apache.org>]

igalshilman commented on a change in pull request #129:
URL: https://github.com/apache/flink-statefun/pull/129#discussion_r465574155



##########
File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/feedback/FeedbackUnionOperatorFactory.java
##########
@@ -65,9 +65,13 @@ public FeedbackUnionOperatorFactory(
             keySelector,
             configuration.getFeedbackBufferSize().getBytes(),
             serializer,
-            mailboxExecutor);
+            mailboxExecutor,
+            streamOperatorParameters.getProcessingTimeService());

Review comment:
       It is not used in the FeedbackUnionOperator

##########
File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/feedback/FeedbackUnionOperator.java
##########
@@ -61,14 +62,16 @@
       SerializableFunction<T, ?> keySelector,
       long totalMemoryUsedForFeedbackCheckpointing,
       TypeSerializer<T> elementSerializer,
-      MailboxExecutor mailboxExecutor) {
+      MailboxExecutor mailboxExecutor,
+      ProcessingTimeService processingTimeService) {
     this.feedbackKey = Objects.requireNonNull(feedbackKey);
     this.isBarrierMessage = Objects.requireNonNull(isBarrierMessage);
     this.keySelector = Objects.requireNonNull(keySelector);
     this.totalMemoryUsedForFeedbackCheckpointing = totalMemoryUsedForFeedbackCheckpointing;
     this.elementSerializer = Objects.requireNonNull(elementSerializer);
     this.mailboxExecutor = Objects.requireNonNull(mailboxExecutor);
     this.chainingStrategy = ChainingStrategy.ALWAYS;
+    this.processingTimeService = processingTimeService;

Review comment:
       Why is this needed here?

##########
File path: statefun-flink/statefun-flink-state-processor/pom.xml
##########
@@ -74,7 +74,12 @@ under the License.
             <type>test-jar</type>
             <scope>test</scope>
         </dependency>
-
+        <dependency>

Review comment:
       Can you explain that dependency? 
   Does it brings something that was previously else where?
   cc: @tzulitai 

##########
File path: tools/docker/flink-distribution-template/conf/flink-conf.yaml
##########
@@ -28,6 +28,7 @@ state.backend: rocksdb
 state.backend.rocksdb.timer-service.factory: ROCKSDB
 state.checkpoints.dir: file:///checkpoint-dir
 state.backend.incremental: true
+jobmanager.memory.process.size: 1g

Review comment:
       Is that a new mandatory parameter? if so the `helm` charts needs to be updated as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org