You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by benbenw <gi...@git.apache.org> on 2016/01/13 00:11:08 UTC
[GitHub] jmeter pull request: bug 58844 : button activation in the argument...
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/69
bug 58844 : button activation in the arguments panel was broken.
Logic wasn't completly implemented.
some buttons were enabled even if the table was empty
move the logic into a single method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter argpanel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit d092332cc032d765bda56aadc95ef3a94b2e91df
Author: benoit <b....@ubik-ingenierie.com>
Date: 2016-01-12T23:08:48Z
button activation in the arguments panel was broken.
Logic wasn't completly implemented.
some buttons were enabled even if the table was empty
move the logic into a single method
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: bug 58844 : button activation in the argument...
Posted by benbenw <gi...@git.apache.org>.
Github user benbenw commented on the pull request:
https://github.com/apache/jmeter/pull/69#issuecomment-171250950
I will not mix code change and indent in my next PRs
But I won't rework this one in the near future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: bug 58844 : button activation in the argument...
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/69#issuecomment-171233558
It would be better to not mixed format/ident changes and fix code changes.
Please can you rework the PR with a new PR with 2 commits, one for fix code changes and one form format code (or 2 PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: bug 58844 : button activation in the argument...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---