You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2022/04/11 20:43:17 UTC
[trafficserver] branch 9.2.x updated: Propagate proxy.config.net.sock_option_flag_in to newly accepted connections (#8784)
This is an automated email from the ASF dual-hosted git repository.
zwoop pushed a commit to branch 9.2.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/9.2.x by this push:
new 1918512c0 Propagate proxy.config.net.sock_option_flag_in to newly accepted connections (#8784)
1918512c0 is described below
commit 1918512c0853f16c970aaa0455d0a5725d6fd986
Author: Randall Meyer <rr...@apache.org>
AuthorDate: Fri Apr 8 11:03:48 2022 -0700
Propagate proxy.config.net.sock_option_flag_in to newly accepted connections (#8784)
* Propagate proxy.config.net.sock_option_flag_in to newly accepted connections
* For client connections, disable setting SO_LINGER by default
This was originally approved under #8463 and was reverted in #8622
(cherry picked from commit e760794ca121396b77ddc01e95ec7b40fbc32c49)
---
doc/admin-guide/files/records.config.en.rst | 2 +-
iocore/net/UnixNetAccept.cc | 2 ++
mgmt/RecordsConfig.cc | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/doc/admin-guide/files/records.config.en.rst b/doc/admin-guide/files/records.config.en.rst
index 33dbfc0c9..a55c074ef 100644
--- a/doc/admin-guide/files/records.config.en.rst
+++ b/doc/admin-guide/files/records.config.en.rst
@@ -4621,7 +4621,7 @@ Sockets
Sets the receive buffer size for connections from the client to |TS|.
-.. ts:cv:: CONFIG proxy.config.net.sock_option_flag_in INT 0x5
+.. ts:cv:: CONFIG proxy.config.net.sock_option_flag_in INT 0x1
Turns different options "on" for the socket handling client connections:::
diff --git a/iocore/net/UnixNetAccept.cc b/iocore/net/UnixNetAccept.cc
index 1ce5923b8..195369584 100644
--- a/iocore/net/UnixNetAccept.cc
+++ b/iocore/net/UnixNetAccept.cc
@@ -348,6 +348,7 @@ NetAccept::do_blocking_accept(EThread *t)
vc->action_ = *action_;
vc->set_is_transparent(opt.f_inbound_transparent);
vc->set_is_proxy_protocol(opt.f_proxy_protocol);
+ vc->options.sockopt_flags = opt.sockopt_flags;
vc->options.packet_mark = opt.packet_mark;
vc->options.packet_tos = opt.packet_tos;
vc->options.packet_notsent_lowat = opt.packet_notsent_lowat;
@@ -500,6 +501,7 @@ NetAccept::acceptFastEvent(int event, void *ep)
vc->action_ = *action_;
vc->set_is_transparent(opt.f_inbound_transparent);
vc->set_is_proxy_protocol(opt.f_proxy_protocol);
+ vc->options.sockopt_flags = opt.sockopt_flags;
vc->options.packet_mark = opt.packet_mark;
vc->options.packet_tos = opt.packet_tos;
vc->options.packet_notsent_lowat = opt.packet_notsent_lowat;
diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index 715369027..974f0e68a 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -770,7 +770,7 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.net.sock_send_buffer_size_in", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
,
- {RECT_CONFIG, "proxy.config.net.sock_option_flag_in", RECD_INT, "0x5", RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
+ {RECT_CONFIG, "proxy.config.net.sock_option_flag_in", RECD_INT, "0x1", RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
,
{RECT_CONFIG, "proxy.config.net.sock_packet_mark_in", RECD_INT, "0x0", RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
,