You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Taro App (JIRA)" <ji...@apache.org> on 2011/01/13 16:39:46 UTC

[jira] Created: (PIVOT-696) TextArea support for entering tab characters and tab stops

TextArea support for entering tab characters and tab stops
----------------------------------------------------------

                 Key: PIVOT-696
                 URL: https://issues.apache.org/jira/browse/PIVOT-696
             Project: Pivot
          Issue Type: Improvement
    Affects Versions: 2.0
            Reporter: Taro App
            Priority: Minor


Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080858#comment-13080858 ] 

Sandro Martini commented on PIVOT-696:
--------------------------------------

Hi all,
should I resolve this ticket in 2.0.1 or move to 2.0.2 ?


> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-696:
---------------------------------

    Affects Version/s: 2.0.1
        Fix Version/s:     (was: 2.0.1)
                       2.0.2
             Assignee: Noel Grandin
              Summary: TextPane support for entering tab characters and tab stops  (was: TextArea support for entering tab characters and tab stops)

As suggested, moved to TextPane and 2.0.2, and assigned to Noel, our TextArea expert.


> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0, 2.0.1
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.0.2
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini reassigned PIVOT-696:
------------------------------------

    Assignee: Roger Whitcomb  (was: Noel Grandin)

Reassigned because Roger is now working on this
                
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.0.3
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-696:
---------------------------------

    Comment: was deleted

(was: Hi all,
should I resolve this ticket in 2.0.1 or move to 2.0.2 ?
)

> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0, 2.0.1
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.2
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-696:
---------------------------------

    Fix Version/s:     (was: 2.1)
                   2.0.3
    
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.0.3
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Chris Bartlett (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079289#comment-13079289 ] 

Chris Bartlett commented on PIVOT-696:
--------------------------------------

I'm inclined to agree with Noel and leave it to TextPane.  I don't see a tutorial section for TextPane though, so is it ready for use yet?

> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498994#comment-13498994 ] 

Roger Whitcomb commented on PIVOT-696:
--------------------------------------

I am going to make a small revision to TextArea to at least convert tabs to spaces in "setText" according to the current "tabWidth" style in the skin.  This will involve adding "getTabWidth" to the TextArea.Skin interface, and putting a bit of code into "setText" to convert tabs to spaces according to this width.

I'm doing this from a user request with our application.  And since Ctrl-Tab already does the same thing, it only seems reasonable to support this in "setText".  Other places could use it also, but this seems the least impact and most useful.

But, of course, the full functionality could still be done in TextPane at some point.
                
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981713#action_12981713 ] 

Sandro Martini commented on PIVOT-696:
--------------------------------------

Verify using a non-proportional font how this is displayed, for example to have a text version of multi-column data inside

> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499116#comment-13499116 ] 

Roger Whitcomb commented on PIVOT-696:
--------------------------------------

Extended the support of converting tabs to appropriate number of spaces to "insertText" also (which means "paste" also works):
[trunk]:
Sending        wtk\src\org\apache\pivot\wtk\TextArea.java
Transmitting file data .
Committed revision 1410555.

[branches/2.0.x]:
Sending        .
Sending        wtk\src\org\apache\pivot\wtk\TextArea.java
Transmitting file data .
Committed revision 1410556.
                
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-696:
---------------------------------

    Fix Version/s: 2.0.1

> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Taro App (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982452#action_12982452 ] 

Taro App commented on PIVOT-696:
--------------------------------

Even if a non-proportional font (Font.MONOSPACED) is used, the same issue exists.


> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499016#comment-13499016 ] 

Roger Whitcomb commented on PIVOT-696:
--------------------------------------

Committed this small change to TextArea:
[trunk]:
Sending        wtk\src\org\apache\pivot\wtk\TextArea.java
Sending        wtk\src\org\apache\pivot\wtk\skin\TextAreaSkin.java
Transmitting file data ..
Committed revision 1410536.

[branches/2.0.x]:
Sending        .
Sending        wtk\src\org\apache\pivot\wtk\TextArea.java
Sending        wtk\src\org\apache\pivot\wtk\skin\TextAreaSkin.java
Transmitting file data ..
Committed revision 1410537.
                
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Noel Grandin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078763#comment-13078763 ] 

Noel Grandin commented on PIVOT-696:
------------------------------------

I don't think this feature belongs in TextArea. 
TextArea is highly optimised for a very simple use-case.

TextPane is where all of the fancy features belong.

As a first step towards this, I have implemented support for CTRL-TAB in TextPane. 

> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIVOT-696) TextArea support for entering tab characters and tab stops

Posted by "Noel Grandin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079357#comment-13079357 ] 

Noel Grandin commented on PIVOT-696:
------------------------------------

It's fine for light use - see the example code in 

org.apache.pivot.demos.text.TextPaneDemo

but it depends on what you expect from a rich text editor. There is still lots off functionality that could be added.


> TextArea support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Priority: Minor
>             Fix For: 2.0.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Sandro Martini (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandro Martini updated PIVOT-696:
---------------------------------

    Affects Version/s:     (was: 2.0.1)
        Fix Version/s:     (was: 2.0.2)
                       2.1
    
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIVOT-696) TextPane support for entering tab characters and tab stops

Posted by "Roger Whitcomb (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIVOT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510205#comment-13510205 ] 

Roger Whitcomb commented on PIVOT-696:
--------------------------------------

I added a new property to TextArea called "expandTabs" which is set to false by default, and which controls whether this tab expansion happens during "setText" and "insertText".  The default behavior (now) will be the same as it was in version 2.0.2, but by setting this property true the new behavior is enabled.

[trunk]:
Sending        wtk\src\org\apache\pivot\wtk\TextArea.java
Transmitting file data .
Committed revision 1417258.

[branches/2.0.x]:
Sending        .
Sending        wtk\src\org\apache\pivot\wtk\TextArea.java
Transmitting file data .
Committed revision 1417259.
                
> TextPane support for entering tab characters and tab stops
> ----------------------------------------------------------
>
>                 Key: PIVOT-696
>                 URL: https://issues.apache.org/jira/browse/PIVOT-696
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Taro App
>            Assignee: Noel Grandin
>            Priority: Minor
>             Fix For: 2.1
>
>
> Currently, if you press Ctrl+Tab in a TextArea, series of space characters entered. (The number of space characters can be specified with tabWidth property.) Text containing tabs can be set by TextArea.setText, but then tab characters are not displayed. It is desirable that TextArea supports tab stops so users can enter and see tab characters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira