[GitHub] [incubator-nuttx] patacongo commented on issue #24: Fix wait loop and void cast

[GitBox <gi...@apache.org>]

patacongo commented on issue #24: Fix wait loop and void cast
URL: https://github.com/apache/incubator-nuttx/pull/24#issuecomment-570288836
 
 
   Removing the (void) cast actually violates the coding standard.  Look at:
   
   http://nuttx.org/Documentation/NuttXCCodingStandard.html#retvalues
   
   **Checking Return Values**. Callers of internal OS functions should always check return values for an error. At a minimum, a debug statement should indicate that an error has occurred. **_The calling logic intentionally ignores the returned value, then the function return value should be explicitly cast to (void) to indicate that the return value is intentionally ignored._** An exception of for standard functions for which people have historically ignored the returned values, such as printf() or close. All calls to malloc or realloc must be checked for failures to allocate memory. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services