[GitHub] [drill] arina-ielchiieva commented on issue #2054: DRILL-6168: Revise format plugin table functions

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on issue #2054: DRILL-6168: Revise format plugin table functions
URL: https://github.com/apache/drill/pull/2054#issuecomment-615128763
 
 
   @paul-rogers changes look good to me. I have ran Functional / Advanced tests and there are four failures. Please take a look and make changes in code or suggest how tests should be updated.
   
   ```
   Data Verification Failures:
   
   /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_2.q
   /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_1.q
   /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_4.q
   /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_13.q
   ```
   
   Detailed output:
   ```
   Data Verification Failures:
   
   Query: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_2.q
   select * from table(`table_function/cr_lf.csv`(type=>'text', lineDelimiter=>'\r\n'))
   
   Baseline: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_2.e
            Expected number of rows: 4
   Actual number of rows from Drill: 4
            Number of matching rows: 0
             Number of rows missing: 4
          Number of rows unexpected: 4
   
   These rows are not expected (first 10):
   ["1","aaa","bbb"]
   ["2","ccc","ddd"]
   ["3","eee",""]
   ["4","fff","ggg"]
   
   These rows are missing (first 10):
   ["3,eee,"] (1 occurence(s))
   ["1,aaa,bbb"] (1 occurence(s))
   ["2,ccc,ddd"] (1 occurence(s))
   ["4,fff,ggg"] (1 occurence(s))
   Query: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_1.q
   select columns[0] from table(`table_function/cr_lf.csv`(type=>'text', lineDelimiter=>'\r\n'))
   
   Baseline: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_1.e
            Expected number of rows: 4
   Actual number of rows from Drill: 4
            Number of matching rows: 0
             Number of rows missing: 4
          Number of rows unexpected: 4
   
   These rows are not expected (first 10):
   1
   2
   3
   4
   
   These rows are missing (first 10):
   3,eee, (1 occurence(s))
   1,aaa,bbb (1 occurence(s))
   2,ccc,ddd (1 occurence(s))
   4,fff,ggg (1 occurence(s))
   Query: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_4.q
   select * from table(`table_function/lf_cr.tsv`(type=>'text', lineDelimiter=>'\n\r'))
   
   Baseline: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_4.e
            Expected number of rows: 4
   Actual number of rows from Drill: 4
            Number of matching rows: 0
             Number of rows missing: 4
          Number of rows unexpected: 4
   
   These rows are not expected (first 10):
   ["1","aaa","bbb"]
   ["2","ccc","ddd"]
   ["3","eee",""]
   ["4","fff","ggg"]
   
   These rows are missing (first 10):
   ["3\teee\t"] (1 occurence(s))
   ["2\tccc\tddd"] (1 occurence(s))
   ["1\taaa\tbbb"] (1 occurence(s))
   ["4\tfff\tggg"] (1 occurence(s))
   Query: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_13.q
   select * from table(`table_function/chinese.txt`(type=>'text',lineDelimiter=>'电脑坏了'))
   
   Baseline: /root/drillAutomation/drill-test-framework/framework/resources/Functional/table_function/positive/data/drill-3149_13.e
            Expected number of rows: 4
   Actual number of rows from Drill: 4
            Number of matching rows: 0
             Number of rows missing: 4
          Number of rows unexpected: 4
   
   These rows are not expected (first 10):
   ["1","aaa","bbb"]
   ["2","ccc","ddd"]
   ["3","eee",""]
   ["4","fff","ggg"]
   
   These rows are missing (first 10):
   ["3,eee,"] (1 occurence(s))
   ["1,aaa,bbb"] (1 occurence(s))
   ["2,ccc,ddd"] (1 occurence(s))
   ["4,fff,ggg"] (1 occurence(s))
   ```
   
   https://github.com/mapr/drill-test-framework/tree/master/framework/resources/Functional/table_function/positive/data
   https://github.com/mapr/drill-test-framework/tree/master/framework/resources/Datasources/table_function

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services