You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/02/11 23:15:40 UTC
Review Request 30897: Set kdc_type in kerberos-env rather than
krb5-conf configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30897/
-----------------------------------------------------------
Review request for Ambari, John Speidel, Robert Nettleton, and Yusaku Sako.
Bugs: AMBARI-9580
https://issues.apache.org/jira/browse/AMBARI-9580
Repository: ambari
Description
-------
Currently, the `kdc_type` value is being set in the `krb5-conf` configuration, it needs to be set in the `kerberos-env` since the data lies outside the realm of the krb5.conf file.
The solution includes altering how the Kerberos Wizard store the kcd_type value and where the backend logic goes to retrieve it.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java ce319e6
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 03b13d6
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml 38f6ab2
ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/krb5-conf.xml 8e6b9ba
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ad6128c
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 0634a37
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3511ae9
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 3dc3d42
ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/KERBEROS.json e0f837b
ambari-web/app/data/HDP2/site_properties.js 2b2294c
Diff: https://reviews.apache.org/r/30897/diff/
Testing
-------
Manually tested in cluster
#Jenkins test results: Pending
Thanks,
Robert Levas
Re: Review Request 30897: Set kdc_type in kerberos-env rather than
krb5-conf configuration
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30897/#review72035
-----------------------------------------------------------
Ship it!
looks good
- John Speidel
On Feb. 11, 2015, 10:15 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30897/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 10:15 p.m.)
>
>
> Review request for Ambari, John Speidel, Robert Nettleton, and Yusaku Sako.
>
>
> Bugs: AMBARI-9580
> https://issues.apache.org/jira/browse/AMBARI-9580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, the `kdc_type` value is being set in the `krb5-conf` configuration, it needs to be set in the `kerberos-env` since the data lies outside the realm of the krb5.conf file.
>
> The solution includes altering how the Kerberos Wizard store the kcd_type value and where the backend logic goes to retrieve it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java ce319e6
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 03b13d6
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml 38f6ab2
> ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/krb5-conf.xml 8e6b9ba
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ad6128c
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 0634a37
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3511ae9
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 3dc3d42
> ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/KERBEROS.json e0f837b
> ambari-web/app/data/HDP2/site_properties.js 2b2294c
>
> Diff: https://reviews.apache.org/r/30897/diff/
>
>
> Testing
> -------
>
> Manually tested in cluster
>
> #Jenkins test results: Pending
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 30897: Set kdc_type in kerberos-env rather than
krb5-conf configuration
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30897/#review72039
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Feb. 11, 2015, 10:15 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30897/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 10:15 p.m.)
>
>
> Review request for Ambari, John Speidel, Robert Nettleton, and Yusaku Sako.
>
>
> Bugs: AMBARI-9580
> https://issues.apache.org/jira/browse/AMBARI-9580
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, the `kdc_type` value is being set in the `krb5-conf` configuration, it needs to be set in the `kerberos-env` since the data lies outside the realm of the krb5.conf file.
>
> The solution includes altering how the Kerberos Wizard store the kcd_type value and where the backend logic goes to retrieve it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java ce319e6
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml 03b13d6
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml 38f6ab2
> ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/configuration/krb5-conf.xml 8e6b9ba
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ad6128c
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py 0634a37
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json 3511ae9
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 3dc3d42
> ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/KERBEROS.json e0f837b
> ambari-web/app/data/HDP2/site_properties.js 2b2294c
>
> Diff: https://reviews.apache.org/r/30897/diff/
>
>
> Testing
> -------
>
> Manually tested in cluster
>
> #Jenkins test results: Pending
>
>
> Thanks,
>
> Robert Levas
>
>