[GitHub] [hudi] xushiyan commented on a diff in pull request #7885: [MINOR] Make sure FTs are run in GH CI

["xushiyan (via GitHub)" <gi...@apache.org>]

xushiyan commented on code in PR #7885:
URL: https://github.com/apache/hudi/pull/7885#discussion_r1099443128


##########
.github/workflows/bot.yml:
##########
@@ -98,7 +98,7 @@ jobs:
           SCALA_PROFILE: 'scala-2.12'
           FLINK_PROFILE: ${{ matrix.flinkProfile }}
         run:
-          mvn test -Punit-tests -D"$SCALA_PROFILE" -D"$FLINK_PROFILE" -pl hudi-examples/hudi-examples-flink $MVN_ARGS
+          mvn test -Punit-tests -Pfunctional-tests -D"$SCALA_PROFILE" -D"$FLINK_PROFILE" -pl hudi-examples/hudi-examples-flink $MVN_ARGS

Review Comment:
   does this work? thought these profiles exclusive to each other. we probably need to duplicate this job to a new one with FT profile replacing UT.



##########
.github/workflows/bot.yml:
##########
@@ -68,7 +68,7 @@ jobs:
           SPARK_PROFILE: ${{ matrix.sparkProfile }}
         if: ${{ !endsWith(env.SPARK_PROFILE, '2.4') }} # skip test spark 2.4 as it's covered by Azure CI
         run:
-          mvn test -Punit-tests -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -pl hudi-common,hudi-spark-datasource/hudi-spark $MVN_ARGS
+          mvn test -Punit-tests -Pfunctional-tests -D"$SCALA_PROFILE" -D"$SPARK_PROFILE" -pl hudi-common,hudi-spark-datasource/hudi-spark $MVN_ARGS

Review Comment:
   ditto. also job name needs update accordingly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org