[jira] [Commented] (HBASE-5886) Add new metric for possible data loss due to puts without WAL

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262994#comment-13262994 ] 

Todd Lipcon commented on HBASE-5886:
------------------------------------

I think the metrics names could be improved here -- "putWithoutWAL" could be "numPutsWithoutWAL" and "possibleDataLossSize" perhaps "mbInMemoryWithoutWAL"?

- in recordPossibleDataLossNoWal, use {{getAndIncrement}} instead of {{incrementAndGet}}, and compare the result to 0 -- otherwise you're doing an extra atomic op and have a potential race
- the warning message should include the client IP address as well as the region ID. Perhaps something like "Client 123.123.123.123 writing data to region abcdef12345 with WAL disabled. Data may be lost in the event of a crash. Will not log further warnings for this region."

- the debug message when setting possibleDataLossSize back to 0 seems unnecessary.

- DEFAULT_WARN_NO_WAL_INTERVAL is unused

                
> Add new metric for possible data loss due to puts without WAL 
> --------------------------------------------------------------
>
>                 Key: HBASE-5886
>                 URL: https://issues.apache.org/jira/browse/HBASE-5886
>             Project: HBase
>          Issue Type: New Feature
>          Components: metrics, regionserver
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>              Labels: metrics
>         Attachments: HBASE-5886-v0.patch
>
>
> Add a metrics to keep track of puts without WAL and possible data loss size.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira